Paths

Table of Contentst

Differential D11734

Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'
ClosedPublic
Actions

Authored by marcin on Apr 23 2024, 3:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 12:43 PM

	Unknown Object (File)
	Sun, Dec 22, 1:01 AM

	Unknown Object (File)
	Sun, Dec 22, 1:01 AM

	Unknown Object (File)
	Sun, Dec 22, 1:01 AM

	Unknown Object (File)
	Sun, Dec 22, 1:01 AM

	Unknown Object (File)
	Sun, Dec 22, 1:01 AM

	Unknown Object (File)
	Sun, Dec 22, 1:01 AM

	Unknown Object (File)
	Thu, Dec 5, 3:38 PM

View All 89 Files

Subscribers

Details

Reviewers

kamil
bartek

Commits

rCOMMe95762eb3911: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'

Summary

This differential introduces backup message field to OrderedBackupItem so that backup message can be fetched from dynamodb.

Test Plan

For now ensure that backup functionality remains unbroken. Very next diff will enable testing with simple button click.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Apr 23 2024, 3:51 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 23 2024, 3:51 AM

marcin added a parent revision: D11733: Update latest backup id search index to include 'msgBackup'.Apr 23 2024, 3:52 AM

marcin edited the summary of this revision. (Show Details)

marcin added a child revision: D11735: Introduce new JSI call to retrieve backup message for latest siwe backup.Apr 23 2024, 3:57 AM

Harbormaster completed remote builds in B28396: Diff 39391.Apr 23 2024, 4:08 AM

marcin requested review of this revision.Apr 23 2024, 4:08 AM

Logic looks good, just some code-style comments

services/backup/src/database/backup_item.rs
217–226 ↗	(On Diff #39391)	Same comment as in https://phab.comm.dev/D11713#inline-70320 - this could be simplified
shared/comm-lib/src/backup/mod.rs
4–11 ↗	(On Diff #39391)	We have a convention of preferring `rename_all` over field-level directives. `backupID` is an exception because it'd be renamed to `backupId` (lowercase `d`).

This revision is now accepted and ready to land.Apr 24 2024, 2:04 AM

marcin added a parent revision: D11781: Move MissingRegistrationDataHandler to NavigationHandler.Apr 26 2024, 1:19 AM

marcin removed a parent revision: D11781: Move MissingRegistrationDataHandler to NavigationHandler.

Rename msg_backup to siwe_backup_msg
Simplify code.

Harbormaster completed remote builds in B28506: Diff 39541.Apr 26 2024, 6:54 AM

Rebase before landing

Harbormaster completed remote builds in B28802: Diff 40003.May 9 2024, 6:49 AM

Closed by commit rCOMMe95762eb3911: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse' (authored by marcin). · Explain WhyMay 9 2024, 7:00 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMe95762eb3911: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

2 lines

services/

backup/

src/

database/

5 lines

http/

handlers/

1 line

shared/

comm-lib/

src/

backup/

3 lines

Diff 39541

native/native_rust_library/src/backup.rs

Loading...

services/backup/src/database/backup_item.rs

Loading...

services/backup/src/http/handlers/backup.rs

Loading...

shared/comm-lib/src/backup/mod.rs

Loading...