Page MenuHomePhabricator
Differential D11730

[lib/web/native] update `MessageID` in ops handling
ClosedPublic
Actions

Authored by kamil on Apr 22 2024, 5:49 PM.
Tags
None
Referenced Files
F3337054: D11730.diff
Thu, Nov 21, 3:32 PM
Unknown Object (File)
Oct 14 2024, 5:30 PM
Unknown Object (File)
Oct 14 2024, 5:30 PM
Unknown Object (File)
Oct 14 2024, 5:30 PM
Unknown Object (File)
Oct 14 2024, 5:29 PM
Unknown Object (File)
Oct 14 2024, 5:29 PM
Unknown Object (File)
Oct 10 2024, 1:57 PM
Unknown Object (File)
Sep 4 2024, 12:08 AM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM83bae84d1b8d: [lib/web/native] update `MessageID` in ops handling
Summary

We need to also be able to get sender's deviceID to send confirmation

Test Plan

FLow & tests

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 22 2024, 5:49 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptApr 22 2024, 5:49 PM
kamil added a child revision: D11731: [lib/web/native] implement sending confirmation of processed message.Apr 22 2024, 5:52 PM
kamil published this revision for review.Apr 23 2024, 6:42 AM
ashoat added inline comments.Apr 23 2024, 9:40 AM
lib/types/db-ops-types.js
5 ↗(On Diff #39381)

Let's rename this to something more specific. We already have MessageData in our JS codebase

tomek accepted this revision.Apr 24 2024, 4:56 AM
tomek added inline comments.
lib/types/db-ops-types.js
6–7 ↗(On Diff #39381)
This revision is now accepted and ready to land.Apr 24 2024, 4:56 AM
kamil updated this revision to Diff 39635.Apr 29 2024, 2:44 AM
  • MessageData -> MessageSourceMetadata
  • make props read-only
Harbormaster completed remote builds in B28563: Diff 39635.Apr 29 2024, 3:00 AM
Closed by commit rCOMM83bae84d1b8d: [lib/web/native] update `MessageID` in ops handling (authored by kamil). · Explain WhyApr 29 2024, 4:01 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM83bae84d1b8d: [lib/web/native] update `MessageID` in ops handling.

Revision Contents
Changeset List

PathSize
lib/
hooks/
12 lines
reducers/
15 lines
12 lines
types/
7 lines
6 lines
4 lines
native/
redux/
4 lines
2 lines
web/
redux/
13 lines

Diff 39635

View Options

lib/hooks/ops-hooks.js

Loading...
View Options

lib/reducers/db-ops-reducer.js

Loading...
View Options

lib/reducers/db-ops-reducer.test.js

Loading...
View Options

lib/types/db-ops-types.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/request-types.js

Loading...
View Options

native/redux/action-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

web/redux/redux-setup.js

Loading...