[web] render `DBOpsHandler` in `TunnelbrokerProvider`
ClosedPublic
Actions

Authored by kamil on Apr 23 2024, 5:17 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMM414c1f3ea27f: [web] render `DBOpsHandler` in `TunnelbrokerProvider`

Summary

We need to use Tunnelbroker to confirm message after successfully processing ops

Test Plan

Being able to call useTunnelbroker in DBOpsHandler and ops working properly on web

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 23 2024, 5:17 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 23 2024, 5:17 AM

kamil added a child revision: D11731: [lib/web/native] implement sending confirmation of processed message.Apr 23 2024, 5:18 AM

Harbormaster completed remote builds in B28402: Diff 39398.Apr 23 2024, 5:34 AM

kamil published this revision for review.Apr 23 2024, 6:42 AM

ashoat added inline comments.Apr 23 2024, 9:41 AM

web/app.react.js
85 ↗	(On Diff #39398)	Can you undo this change?

Are there any actions that need ops processing dispatched before we render TunnelbrokerProvider?

This revision is now accepted and ready to land.Apr 29 2024, 12:42 AM

undo change

Harbormaster completed remote builds in B28573: Diff 39649.Apr 29 2024, 5:11 AM

In D11739#338949, @tomek wrote:

Are there any actions that need ops processing dispatched before we render TunnelbrokerProvider?

I don't think so, there isn't any gate or component that will cause DBOpsHandler not being rendered

Closed by commit rCOMM414c1f3ea27f: [web] render `DBOpsHandler` in `TunnelbrokerProvider` (authored by kamil). · Explain WhyApr 29 2024, 6:04 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM414c1f3ea27f: [web] render `DBOpsHandler` in `TunnelbrokerProvider`.

Revision Contents
Changeset List

Path

Size

web/

app.react.js

2 lines

root.js

2 lines

Diff 39649

View Options

web/app.react.js