Page MenuHomePhabricator
Differential D11902

[native] Create a single base class for all the ops
ClosedPublic
Actions

Authored by tomek on May 6 2024, 6:29 AM.
Tags
None
Referenced Files
F3514937: D11902.id39844.diff
Sun, Dec 22, 7:03 AM
F3513110: D11902.id39989.diff
Sat, Dec 21, 10:33 PM
F3513109: D11902.id39987.diff
Sat, Dec 21, 10:33 PM
F3513108: D11902.id39988.diff
Sat, Dec 21, 10:33 PM
F3513107: D11902.id39844.diff
Sat, Dec 21, 10:33 PM
F3513097: D11902.id.diff
Sat, Dec 21, 10:33 PM
F3513092: D11902.diff
Sat, Dec 21, 10:33 PM
Unknown Object (File)
Wed, Dec 4, 7:10 PM
View All 82 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
varun
Commits
rCOMM4324e85e55a4: [native] Create a single base class for all the ops
Summary

All the base classes were providing the same functions. Also, it is convenient to be able to store all the ops in a single array - in order to process them in a single transaction.

https://linear.app/comm/issue/ENG-6004/wrap-all-store-operations-from-one-action-in-transaction

Test Plan

Opened the app, modified a draft, closed and reopened the app - the draft was correct.

Diff Detail

Repository
rCOMM Comm
Branch
transactions
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 6 2024, 6:29 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 6 2024, 6:29 AM
Harbormaster completed remote builds in B28696: Diff 39844.May 6 2024, 6:49 AM
tomek requested review of this revision.May 6 2024, 6:49 AM
kamil accepted this revision.EditedMay 6 2024, 6:59 AM

I think in a couple of files you can add #include "DBOperationBase.h" to match our convention to always include header

This revision is now accepted and ready to land.May 6 2024, 6:59 AM
tomek added a child revision: D11921: [native] Create a function that processes all the ops.May 7 2024, 7:55 AM
tomek updated this revision to Diff 39987.May 9 2024, 4:11 AM

Add imports

Harbormaster failed remote builds in B28790: Diff 39987!May 9 2024, 4:29 AM
tomek updated this revision to Diff 39988.May 9 2024, 4:59 AM

Fix imports

Harbormaster completed remote builds in B28791: Diff 39988.May 9 2024, 5:16 AM
Closed by commit rCOMM4324e85e55a4: [native] Create a single base class for all the ops (authored by tomek). · Explain WhyMay 9 2024, 5:25 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM4324e85e55a4: [native] Create a single base class for all the ops.

Revision Contents
Changeset List

Diff 39844

View Options

native/cpp/CommonCpp/NativeModules/AuxUserStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommunityStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/DBOperationBase.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/DraftStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/IntegrityStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/KeyserverStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/MessageStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/AuxUserStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/AuxUserStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/CommunityStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/CommunityStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/IntegrityStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/IntegrityStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/KeyserverStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/KeyserverStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/SyncedMetadataStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/SyncedMetadataStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadActivityStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadActivityStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/UserStore.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/ReportStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/SyncedMetadataStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/ThreadActivityStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/ThreadStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/UserStoreOperations.h

Loading...