[identity] add span tracing to identity database.rs file
ClosedPublic
Actions

Authored by will on Apr 28 2024, 11:05 PM.

Details

Reviewers

varun
bartek

Commits

rCOMMb0272d49b183: [identity] add span tracing to identity database.rs file

Summary

Adds span tracing to the database.rs file

Depends on D11826

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Apr 28 2024, 11:05 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 28 2024, 11:05 PM

will added a child revision: D11828: [identity] add span tracing to identity device_list.rs functions.Apr 28 2024, 11:06 PM

Harbormaster completed remote builds in B28550: Diff 39606.Apr 28 2024, 11:20 PM

will requested review of this revision.Apr 28 2024, 11:20 PM

varun accepted this revision.Apr 29 2024, 10:45 AM

This revision is now accepted and ready to land.Apr 29 2024, 10:45 AM

bartek accepted this revision.May 5 2024, 10:40 PM

bartek added inline comments.

services/identity/src/database.rs
1031 ↗	(On Diff #39606)	I don't think we need it here. It's an inner helper function

review feedback

will marked an inline comment as done.May 6 2024, 9:42 AM

Harbormaster completed remote builds in B28711: Diff 39861.May 6 2024, 9:58 AM

Closed by commit rCOMMb0272d49b183: [identity] add span tracing to identity database.rs file (authored by will). · Explain WhyMay 8 2024, 10:33 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMb0272d49b183: [identity] add span tracing to identity database.rs file.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

5 lines

Diff 39944

View Options

services/identity/src/database.rs

[identity] add span tracing to identity database.rs fileClosedPublicActions