Page MenuHomePhabricator

[native] Use processDBStoreOperations function everywhere
ClosedPublic

Authored by tomek on May 7 2024, 8:31 AM.
Tags
None
Referenced Files
F3513616: D11922.diff
Sun, Dec 22, 12:56 AM
F3513114: D11922.id39895.diff
Sat, Dec 21, 10:33 PM
F3513113: D11922.id39991.diff
Sat, Dec 21, 10:33 PM
F3513099: D11922.id.diff
Sat, Dec 21, 10:33 PM
F3513090: D11922.diff
Sat, Dec 21, 10:33 PM
Unknown Object (File)
Mon, Dec 2, 10:10 AM
Unknown Object (File)
Nov 18 2024, 6:27 PM
Unknown Object (File)
Nov 10 2024, 2:59 PM
Subscribers

Details

Summary

We don't need to use async functions that process a single store. They will be deleted in the next diff.

https://linear.app/comm/issue/ENG-6004/wrap-all-store-operations-from-one-action-in-transaction

Depends on D11921

Test Plan

Checked if persisting drafts still works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.May 7 2024, 9:00 AM

Checked if persisting drafts still works.

Why only drafts? We can probably test other stores by making changes in the app, closing keyserver connection and restarting it afterwards. I would also run sth like git grep "commCoreModule.process" before and after applying this diff.

This revision is now accepted and ready to land.May 8 2024, 3:18 AM

Checked if persisting drafts still works.

Why only drafts? We can probably test other stores by making changes in the app, closing keyserver connection and restarting it afterwards. I would also run sth like git grep "commCoreModule.process" before and after applying this diff.

Testing drafts is the easiest, and testing all might take too much time. Going to test e.g. messages and threads too.

As for grepping, in the next diff the functions are removed which effectively verifies if all the usages were replaced.