Page MenuHomePhabricator
Differential D12014

[lib] Move createAsyncMigrate to utils
ClosedPublic
Actions

Authored by tomek on May 13 2024, 5:10 AM.
Tags
None
Referenced Files
F3140747: D12014.id40931.diff
Sun, Nov 3, 5:11 AM
Unknown Object (File)
Fri, Nov 1, 9:09 PM
Unknown Object (File)
Fri, Nov 1, 8:57 AM
Unknown Object (File)
Sat, Oct 12, 6:20 PM
Unknown Object (File)
Sat, Oct 12, 6:20 PM
Unknown Object (File)
Sat, Oct 12, 6:20 PM
Unknown Object (File)
Sat, Oct 12, 6:20 PM
Unknown Object (File)
Sat, Oct 12, 6:20 PM
View All 81 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
varun
Commits
rCOMMc75e3a4b8a2a: [lib] Move createAsyncMigrate to utils
Summary

I need to split createAsyncMigrate function and after this refactoring it won't make sense for these to be in create-async-migrate.js - the new one should bo somewhere in utils. The original createAsyncMigrate should also be placed in utils probably from the beginning.

https://linear.app/comm/issue/ENG-7009/run-redux-migrations-after-the-backup-is-restored

Depends on D11947

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
transactions
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.May 13 2024, 5:10 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 13 2024, 5:10 AM
tomek added inline comments.May 13 2024, 5:12 AM
lib/utils/migration-utils.js
235

For some reason jest was failing on importing the DEFAULT_VERSION which was used here originally. I think we can safely use -1 here because it is tightly coupled with our migrations versions and the only constraint is for it to be lower than the version of any of them.

Harbormaster completed remote builds in B28866: Diff 40109.May 13 2024, 5:26 AM
tomek requested review of this revision.May 13 2024, 5:26 AM
tomek added a child revision: D12015: [lib] Extract a function that runs the migrations.May 13 2024, 6:16 AM
kamil accepted this revision.May 14 2024, 11:45 PM
This revision is now accepted and ready to land.May 14 2024, 11:45 PM
tomek updated this revision to Diff 40228.May 15 2024, 8:16 AM

Rebase

Harbormaster completed remote builds in B28944: Diff 40228.May 15 2024, 8:33 AM
tomek added a parent revision: D11947: [web] Check backup version when restoring.May 20 2024, 3:11 AM
tomek removed a parent revision: D12013: [native] Verify if the backup version is correct.
tomek updated this revision to Diff 40882.Jun 3 2024, 8:31 AM
tomek added a parent revision: D12013: [native] Verify if the backup version is correct.

Rebase

tomek edited the summary of this revision. (Show Details)Jun 3 2024, 8:32 AM
tomek removed a parent revision: D12013: [native] Verify if the backup version is correct.
Harbormaster failed remote builds in B29383: Diff 40882!Jun 3 2024, 9:11 AM
tomek updated this revision to Diff 40931.Jun 4 2024, 3:20 AM

Rebase

Harbormaster completed remote builds in B29430: Diff 40931.Jun 4 2024, 3:36 AM
Closed by commit rCOMMc75e3a4b8a2a: [lib] Move createAsyncMigrate to utils (authored by tomek). · Explain WhyJun 4 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMc75e3a4b8a2a: [lib] Move createAsyncMigrate to utils.

Revision Contents
Changeset List

PathSize
lib/
shared/
utils/
114 lines
native/
redux/
2 lines
web/
redux/
6 lines

Diff 40109

View Options

lib/shared/create-async-migrate.js

Loading...
View Options

lib/utils/migration-utils.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

web/redux/persist.js

Loading...