Paths

Table of Contentst

Differential D11931

[lib] Expose function that processes operations as a part of SQLite API
ClosedPublic
Actions

Authored by tomek on May 8 2024, 3:16 AM.

Tags

None

Referenced Files

	F3305846: D11931.diff
	Mon, Nov 18, 4:32 PM

	Unknown Object (File)
	Sun, Nov 10, 6:24 AM

	Unknown Object (File)
	Oct 19 2024, 8:18 AM

	Unknown Object (File)
	Oct 19 2024, 8:18 AM

	Unknown Object (File)
	Oct 19 2024, 8:18 AM

	Unknown Object (File)
	Oct 19 2024, 8:18 AM

	Unknown Object (File)
	Sep 9 2024, 8:05 AM

	Unknown Object (File)
	Sep 9 2024, 8:05 AM

View All 41 Files

Subscribers

Details

Reviewers

kamil
marcin
varun

Commits

rCOMM0897e32be4a5: [lib] Expose function that processes operations as a part of SQLite API

Summary

This allows us to use the API conveniently in lib.

https://linear.app/comm/issue/ENG-6004/wrap-all-store-operations-from-one-action-in-transaction

Depends on D11923

Test Plan

Flow.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 8 2024, 3:16 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 8 2024, 3:16 AM

Harbormaster completed remote builds in B28750: Diff 39920.May 8 2024, 3:31 AM

tomek requested review of this revision.May 8 2024, 3:31 AM

tomek added a child revision: D11933: [lib] Create a synced metadata key for DB version.May 8 2024, 3:47 AM

marcin accepted this revision.May 9 2024, 2:16 AM

This revision is now accepted and ready to land.May 9 2024, 2:16 AM

Are you planning to update callsites of processDBStoreOperations to use SQLiteAPI?

web/shared-worker/utils/store.js
159 ↗	(On Diff #39920)	created ENG-8075

In D11931#342559, @kamil wrote:

Are you planning to update callsites of processDBStoreOperations to use SQLiteAPI?

There are many places where we're using processDBStoreOperations and in some of them I expect some issues with using config (e.g. in the worker), so I haven't planned to do that in this stack - we can always consider doing it later if we think it will be beneficial.

Closed by commit rCOMM0897e32be4a5: [lib] Expose function that processes operations as a part of SQLite API (authored by tomek). · Explain WhyMay 14 2024, 4:49 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM0897e32be4a5: [lib] Expose function that processes operations as a part of SQLite API.

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

7 lines

utils/

__mocks__/

1 line

native/

database/

3 lines

web/

database/

3 lines

shared-worker/

utils/

2 lines

Diff 40152

lib/types/sqlite-types.js

Loading...

lib/utils/mocks/config.js

Loading...

native/database/sqlite-api.js

Loading...

web/database/sqlite-api.js

Loading...

web/shared-worker/utils/store.js

Loading...