Paths

Table of Contentst

-
lib/
-
handlers/
-
db-ops-handler.react.js
-
types/tunnelbroker/
-
tunnelbroker/
-
peer-to-peer-message-types.js

Differential D12077

[lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`
ClosedPublic
Actions

Authored by kamil on May 16 2024, 9:12 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMMc5c181b5b06f: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`

Summary

This is needed to remove processed message form OutboundP2PMessage's table.

Depends on D12076

Test Plan

Test sending confirmation, use app for a while to make sure this not interfere with processing store ops (login/logout).

Diff Detail

Repository

rCOMM Comm

Branch

publish-broadcasting

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 16 2024, 9:12 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 16 2024, 9:12 AM

Harbormaster completed remote builds in B28990: Diff 40294.May 16 2024, 9:29 AM

kamil published this revision for review.May 16 2024, 9:39 AM

bartek added inline comments.May 17 2024, 2:16 AM

lib/handlers/db-ops-handler.react.js
51	Open question: Does calling `identityContext.getAuthMetadata()` has any advantages over fetching deviceID from Olm using `getContentSigningKey()` from `lib/utils/crypto-utils.js`?

kamil added inline comments.May 17 2024, 3:33 AM

lib/handlers/db-ops-handler.react.js
51	Overall yes, `getAuthMetadata` caches values and on native is subscribed to the emitter which means is reactive to changes of `accessToken`. But looking at implementation, for only `deviceID` is doesn't really matter which method we'll use, this is more about readability. I am open to updating this to use `getContentSigningKey()`. (cc. @tomek)

bartek accepted this revision.May 20 2024, 1:52 AM

bartek added inline comments.

lib/handlers/db-ops-handler.react.js
51	Yeah I'm talking specifically about `deviceID`.

This revision is now accepted and ready to land.May 20 2024, 1:52 AM

kamil added a child revision: D12111: [lib] implement removing OutboundP2P messages after confirmation.May 20 2024, 3:55 AM

address review

kamil added inline comments.May 23 2024, 7:46 AM

lib/handlers/db-ops-handler.react.js
51	I updated `getContentSigningKey` and created ENG-8192 to discuss some improvements.

Harbormaster completed remote builds in B29211: Diff 40582.May 23 2024, 7:49 AM

Closed by commit rCOMMc5c181b5b06f: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed` (authored by kamil). · Explain WhyMay 23 2024, 7:53 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc5c181b5b06f: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

db-ops-handler.react.js

47 lines

types/

tunnelbroker/

peer-to-peer-message-types.js

2 lines

Diff 40294

View Options

lib/handlers/db-ops-handler.react.js

// @flow		// @flow

import type { PossiblyStaleNavigationState } from '@react-navigation/native';		import type { PossiblyStaleNavigationState } from '@react-navigation/native';
		import { useRoute } from '@react-navigation/native';
import _memoize from 'lodash/memoize.js';		import _memoize from 'lodash/memoize.js';
import * as React from 'react';		import * as React from 'react';
import { createSelector } from 'reselect';		import { createSelector } from 'reselect';

import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js';		import { nonThreadCalendarFiltersSelector } from 'lib/selectors/calendar-filter-selectors.js';
import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js';		import { currentCalendarQuery } from 'lib/selectors/nav-selectors.js';
		import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js';		import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { CalendarFilter } from 'lib/types/filter-types.js';		import type { CalendarFilter } from 'lib/types/filter-types.js';
		import type {
		ComposableMessageInfo,
		RobotextMessageInfo,
		} from 'lib/types/message-types.js';
		import type { ThreadInfo } from 'lib/types/thread-types.js';

import type { NavContextType } from './navigation-context.js';		import type { NavContextType } from './navigation-context.js';
import { NavContext } from './navigation-context.js';		import { NavContext } from './navigation-context.js';
import {		import {
getStateFromNavigatorRoute,		getStateFromNavigatorRoute,
getThreadIDFromRoute,		getThreadIDFromRoute,
currentLeafRoute,		currentLeafRoute,
} from './navigation-utils.js';		} from './navigation-utils.js';
import {		import {
AppRouteName,		AppRouteName,
TabNavigatorRouteName,		TabNavigatorRouteName,
MessageListRouteName,		MessageListRouteName,
ChatRouteName,		ChatRouteName,
CalendarRouteName,		CalendarRouteName,
ThreadPickerModalRouteName,		ThreadPickerModalRouteName,
ActionResultModalRouteName,		ActionResultModalRouteName,
accountModals,		accountModals,
scrollBlockingModals,		scrollBlockingModals,
chatRootModals,		chatRootModals,
threadRoutes,		threadRoutes,
CommunityDrawerNavigatorRouteName,		CommunityDrawerNavigatorRouteName,
		MessageResultsScreenRouteName,
		MessageSearchRouteName,
} from './route-names.js';		} from './route-names.js';
import type { RemoveEditMode } from '../chat/message-list-types';		import type { RemoveEditMode } from '../chat/message-list-types';
import { useSelector } from '../redux/redux-utils.js';		import { useSelector } from '../redux/redux-utils.js';
import type { NavPlusRedux } from '../types/selector-types.js';		import type { NavPlusRedux } from '../types/selector-types.js';
import type { GlobalTheme } from '../types/themes.js';		import type { GlobalTheme } from '../types/themes.js';

const baseCreateIsForegroundSelector = (routeName: string) =>		const baseCreateIsForegroundSelector = (routeName: string) =>
createSelector(		createSelector(
▲ Show 20 Lines • Show All 343 Lines • ▼ Show 20 Lines	function useCurrentLeafRouteName(): ?string {
return React.useMemo(() => {		return React.useMemo(() => {
if (!navContext) {		if (!navContext) {
return undefined;		return undefined;
}		}
return currentLeafRoute(navContext.state).name;		return currentLeafRoute(navContext.state).name;
}, [navContext]);		}, [navContext]);
}		}

		function useCanEditMessageNative(
		threadInfo: ThreadInfo,
		targetMessageInfo: ComposableMessageInfo \| RobotextMessageInfo,
		): boolean {
		const route = useRoute();

		const screenKey = route.key;
		const threadCreationTime = threadInfo.creationTime;
		const messageCreationTime = targetMessageInfo.time;

		const canEditInThisScreen =
		!screenKey.startsWith(MessageSearchRouteName) &&
		!screenKey.startsWith(MessageResultsScreenRouteName) &&
		messageCreationTime >= threadCreationTime;

		return (
		useCanEditMessage(threadInfo, targetMessageInfo) && canEditInThisScreen
		);
		}

export {		export {
createIsForegroundSelector,		createIsForegroundSelector,
useIsAppLoggedIn,		useIsAppLoggedIn,
createActiveTabSelector,		createActiveTabSelector,
scrollBlockingModalsClosedSelector,		scrollBlockingModalsClosedSelector,
selectBackgroundIsDark,		selectBackgroundIsDark,
activeThreadSelector,		activeThreadSelector,
activeMessageListSelector,		activeMessageListSelector,
useActiveThread,		useActiveThread,
useActiveMessageList,		useActiveMessageList,
calendarActiveSelector,		calendarActiveSelector,
nativeCalendarQuery,		nativeCalendarQuery,
nonThreadCalendarQuery,		nonThreadCalendarQuery,
useCalendarQuery,		useCalendarQuery,
drawerSwipeEnabledSelector,		drawerSwipeEnabledSelector,
useCurrentLeafRouteName,		useCurrentLeafRouteName,
getRemoveEditMode,		getRemoveEditMode,
getTabNavState,		getTabNavState,
getChatNavStateFromTabNavState,		getChatNavStateFromTabNavState,
		useCanEditMessageNative,
};		};