Page MenuHomePhabricator
Differential D12083

[native] Call goBackToPrompt when registration fails in FullscreenSIWEPanel
ClosedPublic
Actions

Authored by ashoat on May 16 2024, 5:03 PM.
Tags
None
Referenced Files
F3382314: D12083.id40307.diff
Thu, Nov 28, 9:52 AM
F3382286: D12083.id40326.diff
Thu, Nov 28, 9:39 AM
Unknown Object (File)
Sat, Nov 9, 3:18 PM
Unknown Object (File)
Sat, Nov 9, 12:20 PM
Unknown Object (File)
Sat, Nov 9, 8:48 AM
Unknown Object (File)
Fri, Nov 1, 5:15 PM
Unknown Object (File)
Oct 11 2024, 2:53 AM
Unknown Object (File)
Oct 11 2024, 1:43 AM
View All 51 Files
Subscribers
tomek

Details

Reviewers
inka
Commits
rCOMMe4cb78135622: [native] Call goBackToPrompt when registration fails in FullscreenSIWEPanel
Summary

When something goes wrong during registration, we always show an Alert in registrationServerCall.

When registrationServerCall is called from FullscreenSIWEPanel, we want to call goBackToPrompt if it fails, after the user acknowledges the prompt.

Depends on D12082

Test Plan
  1. Force a client_version_unsupported failure by hardcoding it in keyserver/src/session/version.js
  2. Disable enableNewRegistrationMode
  3. Enable usingCommServicesAccessToken
  4. Try FullscreenSIWEPanel with a wallet that hasn't been registered before
  5. Verify that goBackToPrompt is called after acknowledging the Alert

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
account/
1 line
registration/
32 lines
1 line

Diff 40307

View Options

native/account/fullscreen-siwe-panel.react.js

Loading...
View Options

native/account/registration/registration-server-call.js

Loading...
View Options

native/account/registration/registration-types.js

Loading...