Details

Reviewers

kamil
marcin
varun

Summary

Run the Redux migrations using the default state and a restored SQLite. We run these only because they are modifying the SQLIte and we don't care about the Redux state that was transformed - we're using the default state and throw away the result.
In order to run the migrations on the worker, I had to move some things around.

https://linear.app/comm/issue/ENG-7009/run-redux-migrations-after-the-backup-is-restored

Depends on D12016

Test Plan

Create a backup on native, add a migration on web, open the web app, restore a migration and check in the logs if the migration was run. The migration is run, but then processing the ops fails due to https://linear.app/comm/issue/ENG-8102/its-not-possible-to-get-a-worker-from-a-worker.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.May 15 2024, 5:02 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 15 2024, 5:02 AM

tomek added inline comments.May 15 2024, 5:05 AM

web/redux/default-state.js
44–45 ↗	(On Diff #40208)	In the worker context `window` isn't present and we currently don't care about the exact values
74 ↗	(On Diff #40208)	This also isn't set in the worker context
web/shared-worker/worker/backup.js
87–106 ↗	(On Diff #40208)	This is the only interesting part of this diff

tomek added a child revision: D12049: [lib] Add a way of marking migrations as schema-changing.May 15 2024, 5:12 AM

Harbormaster completed remote builds in B28934: Diff 40208.May 15 2024, 5:19 AM

tomek requested review of this revision.May 15 2024, 5:19 AM

ashoat added inline comments.May 15 2024, 5:26 PM

web/redux/default-state.js
44–45 ↗	(On Diff #40208)	I don't have much context on the rest of the stack, but I'm wondering if you can explain the significance of this change a bit more. Are there states where the app will now have `{ width: 0, height: 0 }` in its Redux state now? Or is this part of `defaultState` not actually used on the web worker?

tomek added inline comments.May 16 2024, 12:57 AM

web/redux/default-state.js
44–45 ↗	(On Diff #40208)	The Redux state always has the correct value. This change only affects the default state which we use to perform the DB migration on the worker and then throw away.