Page MenuHomePhabricator
Differential D12130

[web][native] persist Outbound P2P messages when processing store ops
ClosedPublic
Actions

Authored by kamil on May 20 2024, 4:20 PM.
Tags
None
Referenced Files
F3348581: D12130.id40421.diff
Fri, Nov 22, 3:16 PM
F3346759: D12130.diff
Fri, Nov 22, 9:46 AM
Unknown Object (File)
Fri, Nov 8, 10:39 PM
Unknown Object (File)
Oct 23 2024, 5:26 AM
Unknown Object (File)
Oct 23 2024, 4:01 AM
Unknown Object (File)
Oct 20 2024, 2:08 AM
Unknown Object (File)
Oct 20 2024, 1:52 AM
Unknown Object (File)
Oct 19 2024, 9:42 PM
View All 50 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM5f77f1fdae37: [web][native] persist Outbound P2P messages when processing store ops
Summary

It's important to address messages to the other peers in the same SQLite transaction as updating our own store (we don't have state-sync yet so this allows us to make sure data is consistent).

Later on, this data will be encrypted and sent through Tunnelbroker (D12132).

Depends on D12129

Test Plan

Make sure messages are persisted (added some mock and read it later).
Tested end-to-end in: D12133

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 20 2024, 4:20 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMay 20 2024, 4:20 PM
kamil added a child revision: D12131: [lib] creating `olm` session with device.May 20 2024, 4:31 PM
Harbormaster completed remote builds in B29072: Diff 40421.May 20 2024, 4:39 PM
kamil published this revision for review.May 21 2024, 1:23 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the summary of this revision. (Show Details)
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
430–469

I guess this could be extracted to a separate function but wondering what reviewers think

bartek accepted this revision.May 23 2024, 6:38 AM
This revision is now accepted and ready to land.May 23 2024, 6:38 AM
Closed by commit rCOMM5f77f1fdae37: [web][native] persist Outbound P2P messages when processing store ops (authored by kamil). · Explain WhyMay 24 2024, 8:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM5f77f1fdae37: [web][native] persist Outbound P2P messages when processing store ops.

Revision Contents
Changeset List

PathSize
lib/
types/
3 lines
native/
cpp/
CommonCpp/
DatabaseManagers/
entities/
17 lines
NativeModules/
45 lines
redux/
2 lines
web/
shared-worker/
utils/
2 lines
worker/
4 lines

Diff 40421

View Options

lib/types/store-ops-types.js

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/OutboundP2PMessage.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/redux/redux-utils.js

Loading...
View Options

web/shared-worker/utils/store.js

Loading...
View Options

web/shared-worker/worker/process-operations.js

Loading...