Page MenuHomePhabricator
Differential D12114

[lib][native][web] Introduce useSecondaryDeviceLogIn
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 3:59 AM.
Tags
None
Referenced Files
F3400244: D12114.id40388.diff
Mon, Dec 2, 6:45 AM
F3400220: D12114.id40437.diff
Mon, Dec 2, 6:40 AM
F3400207: D12114.id40429.diff
Mon, Dec 2, 6:36 AM
F3399808: D12114.diff
Mon, Dec 2, 4:48 AM
Unknown Object (File)
Fri, Nov 8, 9:48 AM
Unknown Object (File)
Thu, Nov 7, 2:40 PM
Unknown Object (File)
Thu, Nov 7, 10:06 AM
Unknown Object (File)
Thu, Nov 7, 8:53 AM
View All 71 Files
Subscribers
None

Details

Reviewers
bartek
tomek
Commits
rCOMMb4e3bcbd2ac2: [lib][native][web] Introduce useSecondaryDeviceLogIn
Summary

This diff does two things:

  1. Factors out shared logic around secondary device login on web and native
  2. Makes sure we perform authoritative keyserver auth as part of that. This mostly addresses ENG-8123

Depends on D12113

Test Plan

I tested the flow using staging, with my phone as a primary device and a local simulator as a secondary device

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 20 2024, 3:59 AM
ashoat added a child revision: D12115: [native][web] Avoid clearing unauthorizedDeviceID twice.
Harbormaster completed remote builds in B29051: Diff 40388.May 20 2024, 4:31 AM
ashoat requested review of this revision.May 20 2024, 4:31 AM
bartek accepted this revision.May 20 2024, 7:46 AM
bartek added inline comments.
web/account/qr-code-login.react.js
70 ↗(On Diff #40388)

sounds a bit more natural, but no strong opinion

This revision is now accepted and ready to land.May 20 2024, 7:46 AM
ashoat updated this revision to Diff 40429.May 21 2024, 1:00 AM

Review

This revision was landed with ongoing or failed builds.May 21 2024, 1:11 AM
Closed by commit rCOMMb4e3bcbd2ac2: [lib][native][web] Introduce useSecondaryDeviceLogIn (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb4e3bcbd2ac2: [lib][native][web] Introduce useSecondaryDeviceLogIn.
Harbormaster completed remote builds in B29080: Diff 40429.May 21 2024, 1:15 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
24 lines
hooks/
22 lines
native/
qr-code/
24 lines
web/
account/
30 lines

Diff 40437

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/hooks/login-hooks.js

Loading...
View Options

native/qr-code/qr-code-screen.react.js

Loading...
View Options

web/account/qr-code-login.react.js

Loading...