To make sure the order is correct also on the sender's side we have to do it in exactly the same SQLite transaction.
A similar approach to decryptSequentialAndPersist.
Depends on D12080
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 1392 ↗ | (On Diff #40420) | This is some code duplication with CommCoreModule::encrypt but it's not that easy to dedupplicate it |
| 1421–1427 ↗ | (On Diff #40420) | we have to do it here in C++ to keep this in one transaction. Alternative would be updated table to have two columns: ciphertext_message and ciphertext_message_type but I think this approach is okay too, there are multiple usages of folly::toJson in our codebase |