Paths

Table of Contentst

Differential D12129

[web][native] implement encrypting and persisting OutboundP2PMessage's content in the same SQLite transaction as persisting `olm` session
ClosedPublic
Actions

Authored by kamil on May 20 2024, 4:00 PM.

Tags

None

Referenced Files

	F3346504: D12129.diff
	Fri, Nov 22, 8:57 AM

	Unknown Object (File)
	Sun, Nov 17, 4:52 AM

	Unknown Object (File)
	Oct 14 2024, 4:27 PM

	Unknown Object (File)
	Oct 14 2024, 4:27 PM

	Unknown Object (File)
	Oct 14 2024, 4:27 PM

	Unknown Object (File)
	Oct 14 2024, 4:26 PM

	Unknown Object (File)
	Oct 1 2024, 1:03 PM

	Unknown Object (File)
	Sep 21 2024, 10:05 AM

View All 50 Files

Subscribers

Details

Reviewers

tomek
marcin

Commits

rCOMMcf875d56dede: [web][native] implement encrypting and persisting OutboundP2PMessage's content…

Summary

To make sure the order is correct also on the sender's side we have to do it in exactly the same SQLite transaction.

A similar approach to decryptSequentialAndPersist.

Depends on D12080

Test Plan

Call this method and make sure data is persisted. Tested end-to-end in D12133.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 20 2024, 4:00 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 20 2024, 4:00 PM

Harbormaster completed remote builds in B29071: Diff 40420.May 20 2024, 4:19 PM

kamil added a child revision: D12130: [web][native] persist Outbound P2P messages when processing store ops.May 20 2024, 4:20 PM

kamil edited the summary of this revision. (Show Details)May 21 2024, 1:19 AM

kamil edited the test plan for this revision. (Show Details)

kamil published this revision for review.May 21 2024, 1:22 AM

kamil added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1392 ↗	(On Diff #40420)	This is some code duplication with `CommCoreModule::encrypt` but it's not that easy to dedupplicate it
1421–1427 ↗	(On Diff #40420)	we have to do it here in C++ to keep this in one transaction. Alternative would be updated table to have two columns: `ciphertext_message` and `ciphertext_message_type` but I think this approach is okay too, there are multiple usages of `folly::toJson` in our codebase

marcin accepted this revision.May 24 2024, 5:24 AM

This revision is now accepted and ready to land.May 24 2024, 5:24 AM

Closed by commit rCOMMcf875d56dede: [web][native] implement encrypting and persisting OutboundP2PMessage's content… (authored by kamil). · Explain WhyMay 24 2024, 8:39 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMcf875d56dede: [web][native] implement encrypting and persisting OutboundP2PMessage's content….

Revision Contents
Changeset List

Path

Size

lib/

types/

crypto-types.js

5 lines

utils/

__mocks__/

1 line

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

5 lines

CommCoreModule.cpp

80 lines

_generated/

commJSI-generated.cpp

crypto/

1 line

schema/

CommCoreModuleSchema.js

5 lines

web/

crypto/

1 line

shared-worker/

worker/

worker-crypto.js

44 lines

Diff 40638

lib/types/crypto-types.js

Loading...

lib/utils/mocks/config.js

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/crypto/olm-api.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...

web/crypto/olm-api.js

Loading...

web/shared-worker/worker/worker-crypto.js

Loading...