Page MenuHomePhabricator

[native_rust_library] fix serialization of BackupKeysResult
ClosedPublic

Authored by varun on May 24 2024, 9:00 AM.
Tags
None
Referenced Files
F3281735: D12212.id40642.diff
Sat, Nov 16, 10:04 AM
Unknown Object (File)
Wed, Nov 13, 2:03 PM
Unknown Object (File)
Sun, Nov 10, 1:38 AM
Unknown Object (File)
Fri, Nov 8, 8:24 PM
Unknown Object (File)
Thu, Nov 7, 11:17 PM
Unknown Object (File)
Thu, Nov 7, 11:05 PM
Unknown Object (File)
Oct 16 2024, 3:29 AM
Unknown Object (File)
Oct 15 2024, 4:16 PM

Details

Summary

the validator in secondary-device-qr-code-scanner-react.js expects the field names to be camelCase

Depends on D12211

Test Plan
const backupKeys = assertWithValidator<BackupKeys>(
  JSON.parse(backupKeysResponse),
  backupKeysValidator,
);

this assertion in secondary-device-qr-code-scanner-react.js was failing, but now succeeds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.May 24 2024, 9:15 AM

The only changes here after the rebase are code comments – did you accidentally commit the actual code changes separately?

bartek added a subscriber: marcin.

The only changes here after the rebase are code comments – did you accidentally commit the actual code changes separately?

This was fixed by @marcin in D12035. @varun might have been on an outdated master.

Regardless, these comments are good to have.

This revision is now accepted and ready to land.May 26 2024, 1:39 AM