Page MenuHomePhabricator
Differential D12212

[native_rust_library] fix serialization of BackupKeysResult
ClosedPublic
Actions

Authored by varun on May 24 2024, 9:00 AM.
Tags
None
Referenced Files
F3281735: D12212.id40642.diff
Sat, Nov 16, 10:04 AM
Unknown Object (File)
Wed, Nov 13, 2:03 PM
Unknown Object (File)
Sun, Nov 10, 1:38 AM
Unknown Object (File)
Fri, Nov 8, 8:24 PM
Unknown Object (File)
Thu, Nov 7, 11:17 PM
Unknown Object (File)
Thu, Nov 7, 11:05 PM
Unknown Object (File)
Oct 16 2024, 3:29 AM
Unknown Object (File)
Oct 15 2024, 4:16 PM
View All 74 Files
Subscribers
ashoat
marcin
tomek

Details

Reviewers
bartek
kamil
Commits
rCOMM0179df617f89: [native_rust_library] fix serialization of BackupKeysResult
Summary

the validator in secondary-device-qr-code-scanner-react.js expects the field names to be camelCase

Depends on D12211

Test Plan
const backupKeys = assertWithValidator<BackupKeys>(
  JSON.parse(backupKeysResponse),
  backupKeysValidator,
);

this assertion in secondary-device-qr-code-scanner-react.js was failing, but now succeeds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.May 24 2024, 9:00 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 24 2024, 9:00 AM
varun added a child revision: D12213: [keyserver] finish secondary login via qr code.May 24 2024, 9:02 AM
Harbormaster completed remote builds in B29242: Diff 40642.May 24 2024, 9:15 AM
varun requested review of this revision.May 24 2024, 9:15 AM
varun updated this revision to Diff 40651.May 24 2024, 9:38 AM

rebase

Harbormaster completed remote builds in B29245: Diff 40651.May 24 2024, 9:54 AM
ashoat added a comment.May 25 2024, 7:33 AM

The only changes here after the rebase are code comments – did you accidentally commit the actual code changes separately?

bartek accepted this revision.May 26 2024, 1:39 AM
bartek added a subscriber: marcin.
In D12212#347677, @ashoat wrote:

The only changes here after the rebase are code comments – did you accidentally commit the actual code changes separately?

This was fixed by @marcin in D12035. @varun might have been on an outdated master.

Regardless, these comments are good to have.

This revision is now accepted and ready to land.May 26 2024, 1:39 AM
Closed by commit rCOMM0179df617f89: [native_rust_library] fix serialization of BackupKeysResult (authored by varun). · Explain WhyMay 28 2024, 1:03 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM0179df617f89: [native_rust_library] fix serialization of BackupKeysResult.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
native_rust_library/
src/
3 lines

Diff 40642

View Options

lib/types/backup-types.js

Loading...
View Options

native/native_rust_library/src/backup.rs

Loading...