[lib] Send logout message to primary device in useSecondaryDeviceLogOut
ClosedPublic
Actions

Authored by bartek on May 28 2024, 4:27 AM.

Details

Reviewers

kamil

Commits

rCOMMa98182e55a85: [lib] Send logout message to primary device in useSecondaryDeviceLogOut

Summary

Added Tunnelbroker message types, the same way as in D12133
Extend useSecondaryDeviceLogOut() to send Olm-encrypted TB message to the primary device before performing actual logout

Depends on D12223, D12240

Test Plan

Pressing "Secondary device logout" dev button makes primary device print a log:

LOG  Decrypted message from device mJc0HgRtPM1WTp+SWy/VE4C+243IznJPf2TGvriZ4A4: {"type":"LOG_OUT_SECONDARY_DEVICE"}

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 28 2024, 4:27 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 28 2024, 4:27 AM

bartek added a child revision: D12225: [lib][p2p] Update device list upon receiving logout message.May 28 2024, 4:28 AM

Harbormaster completed remote builds in B29260: Diff 40678.May 28 2024, 4:43 AM

Clean up and rebase

bartek added a parent revision: D12240: [lib] Add unit tests for functions modifying device list.May 29 2024, 9:50 AM

bartek edited the summary of this revision. (Show Details)May 29 2024, 9:52 AM

bartek edited the test plan for this revision. (Show Details)

bartek retitled this revision from [DRAFT] Send logout message to primary device to [lib] Send logout message to primary device in useSecondaryDeviceLogOut.May 29 2024, 9:55 AM

Harbormaster completed remote builds in B29289: Diff 40754.May 29 2024, 10:11 AM

bartek published this revision for review.May 29 2024, 10:14 AM

bartek added inline comments.

lib/actions/user-actions.js
263–273	Not sure about this part but it works. I took it from the stack of D12133. I used `olmAPI.encrypt` instead of `encryptAndPersist` because we're about to log out so there's no point in persisting this. Correct me if I'm wrong

kamil added inline comments.Jun 6 2024, 12:55 AM

lib/actions/user-actions.js
64–65	can be merged
246	debug leftover?
263–273	Not sure about this part but it works. I took it from the stack of D12133. I used `olmAPI.encrypt` instead of `encryptAndPersist` because we're about to log out so there's no point in persisting this. Correct me if I'm wrong makes sense However, in that case, you should first attempt to encrypt, and only if the session does not exist call `createOlmSessionWithPeer` - if there is a session this code will overwrite the existing one and use the new session to encrypt which could cause some issues, and is not what we want.
279–282	what if the user e.g. has no internet connection but logs out anyway and his device cannot send messages through TB?

bartek added inline comments.Jun 6 2024, 1:13 AM

lib/actions/user-actions.js
263–273	Good to know, I'll add a try-catch
279–282	Created a task to discuss it: https://linear.app/comm/issue/ENG-8380/log-out-with-no-internet-connection