Paths

Table of Contentst

[identity] Fetch platform details along with device lists
ClosedPublic
Actions

Authored by bartek on Jun 3 2024, 4:22 AM.

Details

Reviewers

varun
marcin
will

Commits

rCOMMe11f39eb3fd0: [identity] Fetch platform details along with device lists

Summary

Following D12272, updated device list multifetch RPC handler to additionally include PlatformDetails for each device.

Depends on D12272

Test Plan

Repeated test plan for previous diffs in the stack (login devices).
Then called the RPC. Verify that response contains platform details for each device.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 3 2024, 4:22 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 3 2024, 4:22 AM

Harbormaster failed remote builds in B29352: Diff 40837!Jun 3 2024, 4:24 AM

bartek added a child revision: D12274: [identity][protos] Add RPC to update PlatformDetails.Jun 3 2024, 4:29 AM

bartek published this revision for review.Jun 3 2024, 5:46 AM

bartek added inline comments.

services/identity/src/grpc_services/authenticated.rs
526–536	Not sure if nested function is the right way, might be better to inline it

Harbormaster completed remote builds in B29352: Diff 40837.Jun 3 2024, 8:15 AM

bartek added inline comments.Jun 3 2024, 8:53 AM

services/identity/src/grpc_services/authenticated.rs
597	Lost this change during rebase

Add missing uncommitted change

Harbormaster completed remote builds in B29417: Diff 40918.Jun 4 2024, 1:24 AM

marcin accepted this revision.Jun 4 2024, 9:01 AM

This revision is now accepted and ready to land.Jun 4 2024, 9:01 AM

Closed by commit rCOMMe11f39eb3fd0: [identity] Fetch platform details along with device lists (authored by bartek). · Explain WhyJun 6 2024, 6:11 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe11f39eb3fd0: [identity] Fetch platform details along with device lists.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

11 lines

grpc_services/

authenticated.rs

43 lines

Diff 40837

View Options

services/identity/src/database/device_list.rs