[lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 1:03 PM.

Details

Reviewers

Commits

Summary

Consuming hook similar to D12287 in web/ChatInputBar and then removing threadFrozenDueToViewerBlock altogether since it is no longer used.

Depends on D12287

Test Plan

flow and basic logging in hook and in ChatInputBar component

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

atul published this revision for review.Jun 3 2024, 1:04 PM

tomek added inline comments.

web/chat/chat-input-bar.react.js
691	Should we keep the longer name `threadFrozenDueToViewerBlock`?

This revision is now accepted and ready to land.Jun 4 2024, 1:24 AM

ashoat added inline comments.

web/chat/chat-input-bar.react.js
347–350	Can you reevaluate whether each of these props still need to be passed to the class component? It looks like at least `communityThreadInfo` can be removed, for instance

rebase before addressing feedback + landing

remove communityThreadInfo and userInfos props

atul edited the test plan for this revision. (Show Details)Jun 16 2024, 5:04 PM

atul added inline comments.

web/chat/chat-input-bar.react.js
691	Figured `threadFrozen` was more concise and the reasoning for thread being frozen doesn't matter "inside" the component? Can put up followup changing to `threadFrozenDueToViewerBlock` is that's preferred.