Page MenuHomePhabricator

[lib] reverse conditional logic for convertOpsToClientDBOps in message store ops
ClosedPublic

Authored by ginsu on May 25 2024, 4:28 AM.
Tags
None
Referenced Files
F3495733: D12214.id40986.diff
Thu, Dec 19, 9:48 AM
F3495698: D12214.id40988.diff
Thu, Dec 19, 9:43 AM
F3494899: D12214.diff
Thu, Dec 19, 7:14 AM
Unknown Object (File)
Wed, Dec 18, 6:34 AM
Unknown Object (File)
Wed, Dec 18, 6:34 AM
Unknown Object (File)
Wed, Dec 18, 6:34 AM
Unknown Object (File)
Wed, Dec 18, 6:34 AM
Unknown Object (File)
Wed, Dec 18, 6:34 AM
Subscribers

Details

Summary

In the next diff I will introduce the logic to handle the local field in the message store using the ops approach. As a preliminary step to this introduction, I needed to reverse this logic here so that I can add additional conditions in the next diff.

Test Plan

Confirmed that there are no regressions with message store + tested the entire stack at the end of the hackathon

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: tomek, kamil, will.
ginsu requested review of this revision.May 25 2024, 4:58 AM
This revision is now accepted and ready to land.May 27 2024, 2:45 AM
This revision was landed with ongoing or failed builds.Jun 5 2024, 10:26 AM
This revision was automatically updated to reflect the committed changes.