Page MenuHomePhabricator
Differential D12239

[lib] Add function to remove device from device list
ClosedPublic
Actions

Authored by bartek on May 29 2024, 9:48 AM.
Tags
None
Referenced Files
F3386494: D12239.id40752.diff
Fri, Nov 29, 5:01 AM
Unknown Object (File)
Mon, Nov 18, 6:33 AM
Unknown Object (File)
Tue, Nov 12, 2:04 AM
Unknown Object (File)
Tue, Nov 12, 12:42 AM
Unknown Object (File)
Mon, Nov 11, 10:14 PM
Unknown Object (File)
Mon, Nov 11, 5:40 PM
Unknown Object (File)
Sat, Nov 2, 12:46 AM
Unknown Object (File)
Sat, Nov 2, 12:45 AM
View All 52 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMMa22a27c78679: [lib] Add function to remove device from device list
Summary

Analogical to addDeviceToDeviceList(), added a function that removes a device.

Depends on D12238

Test Plan

Unit tests added in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.May 29 2024, 9:48 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 29 2024, 9:48 AM
bartek added a child revision: D12240: [lib] Add unit tests for functions modifying device list.May 29 2024, 9:49 AM
Harbormaster completed remote builds in B29287: Diff 40752.May 29 2024, 10:05 AM
bartek published this revision for review.May 29 2024, 10:12 AM
kamil accepted this revision.Jun 3 2024, 4:40 AM
kamil added inline comments.
lib/shared/device-list-utils.js
211 ↗(On Diff #40752)

Just wondering, shouldn't we throw here? Is there any use-case where we might know that we're attempting to remove a non-existing device?

This revision is now accepted and ready to land.Jun 3 2024, 4:40 AM
bartek added inline comments.Jun 6 2024, 12:48 AM
lib/shared/device-list-utils.js
211 ↗(On Diff #40752)

In theory we could throw, but I wanted to keep parity with adding device to list which is idempotent if device already exist.

Closed by commit rCOMMa22a27c78679: [lib] Add function to remove device from device list (authored by bartek). · Explain WhyJun 6 2024, 1:50 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMa22a27c78679: [lib] Add function to remove device from device list.

Revision Contents
Changeset List

PathSize
lib/
shared/
25 lines

Diff 41027

View Options

lib/shared/device-list-utils.js

Loading...