Page MenuHomePhabricator

[identity] Get device PlatformDetails from metadata
ClosedPublic

Authored by bartek on Jun 3 2024, 4:14 AM.
Tags
None
Referenced Files
F2902227: D12271.id40835.diff
Sat, Oct 5, 4:28 PM
Unknown Object (File)
Sat, Sep 14, 11:10 PM
Unknown Object (File)
Sat, Sep 14, 6:31 PM
Unknown Object (File)
Sat, Sep 14, 7:17 AM
Unknown Object (File)
Tue, Sep 10, 4:39 PM
Unknown Object (File)
Tue, Sep 10, 4:39 PM
Unknown Object (File)
Tue, Sep 10, 4:38 PM
Unknown Object (File)
Tue, Sep 10, 4:36 PM
Subscribers

Details

Summary

Passed metadata PlatformDetails all the way through to DDB storage in all login/registration actions (where DeviceKeyUpload is present)
Added parsing and verification for device type.

Depends on D12270

Test Plan

Combined test plans from D12269 and D12270:

  • Modified client to have additional metadata args
  • Called LogInUser to verify that they're stored in DDB
  • Deliberately malfolmed client device_type to make sure DeviceKeyUpload value is preferred and a warning is displayed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable