This differential ensures automatic platofrm details updates on both clients.
Details
Details
Repeat test plan for parent diff but but this time don't call anything from JS. It should be done automatically.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think we should make sure that this is being run only once, e.g. by introducing a hasRun ref, like in native/components/version-supported.react.js
By the way, do you think it makes sense to merge this with VersionSupportedChecker component? cc @varun
| lib/components/platform-details-synchronizer.react.js | ||
|---|---|---|
| 10 ↗ | (On Diff #40961) | |
Comment Actions
By the way, do you think it makes sense to merge this with VersionSupportedChecker component?
I was thinking about this but I couldn't find any compelling arguments against neither of those solutions. What made me finally decide to use separate component was that we have two different components to check version support on native on web. However this logic is exactly the same for both platforms so putting it inside version support checkers would result in code duplication.
EDIT:
In order to both avoid duplication and additional component we could extract this logic into a hook and use the hook in version support checkers. cc @varun , @ashoat what do you think?
| lib/components/platform-details-synchronizer.react.js | ||
|---|---|---|
| 10 ↗ | (On Diff #40961) | MinVersionHandler on web (VersionSupportChecker equivalent) is also typed like this. I will patch the fix into this diff. |