Page MenuHomePhabricator
Differential D12343

[commtest] Get rid of hardcoded ClientPublicKeys values
ClosedPublic
Actions

Authored by bartek on Jun 6 2024, 11:34 PM.
Tags
None
Referenced Files
F2897010: D12343.id41087.diff
Fri, Oct 4, 9:37 PM
Unknown Object (File)
Thu, Oct 3, 4:27 AM
Unknown Object (File)
Wed, Oct 2, 11:59 PM
Unknown Object (File)
Wed, Oct 2, 11:35 PM
Unknown Object (File)
Wed, Oct 2, 4:57 PM
Unknown Object (File)
Wed, Oct 2, 10:10 AM
Unknown Object (File)
Sun, Sep 29, 4:45 AM
Unknown Object (File)
Sun, Sep 29, 1:23 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
will
varun
marcin
Commits
rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values
Summary

Depends on D12342

Removed hardcoded ClientPublicKeys constants and replaced usages with new implementation

Test Plan

Commtest

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 6 2024, 11:34 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2024, 11:34 PM
bartek added a child revision: D12344: [commtest] Rename SigningCapableAccount to MockOlmAccount.Jun 6 2024, 11:35 PM
Harbormaster failed remote builds in B29513: Diff 41086!Jun 6 2024, 11:38 PM
bartek updated this revision to Diff 41091.Jun 7 2024, 1:36 AM

Try rebase on flaky test fix

Harbormaster failed remote builds in B29518: Diff 41091!Jun 7 2024, 1:42 AM
bartek published this revision for review.Jun 7 2024, 4:03 AM

Keyserver CI unrelated

Harbormaster completed remote builds in B29518: Diff 41091.Jun 9 2024, 11:26 PM
kamil accepted this revision.Jun 10 2024, 10:14 AM

Nice to see that 👏

This revision is now accepted and ready to land.Jun 10 2024, 10:14 AM
Closed by commit rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values (authored by bartek). · Explain WhyJun 12 2024, 7:31 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values.

Revision Contents
Changeset List

Diff 41086

View Options

services/commtest/src/identity/olm_account_infos.rs

Loading...
View Options

services/commtest/tests/identity_device_list_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_persist_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_recipient_confirmation_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs

Loading...