Paths

Table of Contentst

[commtest] Get rid of hardcoded ClientPublicKeys values
ClosedPublic
Actions

Authored by bartek on Jun 7 2024, 6:34 AM.

Details

Reviewers

kamil
will
varun
marcin

Commits

rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values

Summary

Depends on D12342

Removed hardcoded ClientPublicKeys constants and replaced usages with new implementation

Test Plan

Commtest

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 7 2024, 6:34 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2024, 6:34 AM

bartek added a child revision: D12344: [commtest] Rename SigningCapableAccount to MockOlmAccount.Jun 7 2024, 6:35 AM

Harbormaster failed remote builds in B29513: Diff 41086!Jun 7 2024, 6:38 AM

Try rebase on flaky test fix

Harbormaster failed remote builds in B29518: Diff 41091!Jun 7 2024, 8:42 AM

Keyserver CI unrelated

Harbormaster completed remote builds in B29518: Diff 41091.Jun 10 2024, 6:26 AM

Nice to see that 👏

This revision is now accepted and ready to land.Jun 10 2024, 5:14 PM

Closed by commit rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values. · Explain WhyJun 12 2024, 2:31 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM1869f7cedecc: [commtest] Get rid of hardcoded ClientPublicKeys values.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

olm_account_infos.rs

34 lines

tests/

identity_device_list_tests.rs

45 lines

tunnelbroker_integration_tests.rs

7 lines

tunnelbroker_persist_tests.rs

7 lines

tunnelbroker_recipient_confirmation_tests.rs

19 lines

tunnelbroker_sender_confirmation_tests.rs

11 lines

tunnelbroker_websocket_messages_tests.rs

5 lines

Diff 41086

View Options

services/commtest/src/identity/olm_account_infos.rs

View Options

services/commtest/tests/identity_device_list_tests.rs

View Options

services/commtest/tests/tunnelbroker_integration_tests.rs

View Options

services/commtest/tests/tunnelbroker_persist_tests.rs

View Options

services/commtest/tests/tunnelbroker_recipient_confirmation_tests.rs

View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

View Options

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs

[commtest] Get rid of hardcoded ClientPublicKeys valuesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41086

services/commtest/src/identity/olm_account_infos.rs

services/commtest/tests/identity_device_list_tests.rs

services/commtest/tests/tunnelbroker_integration_tests.rs

services/commtest/tests/tunnelbroker_persist_tests.rs

services/commtest/tests/tunnelbroker_recipient_confirmation_tests.rs

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

services/commtest/tests/tunnelbroker_websocket_messages_tests.rs

[commtest] Get rid of hardcoded ClientPublicKeys values
ClosedPublic
Actions

Revision Contents
Changeset List