Page MenuHomePhabricator

[keyserver] Extend link creation logic to support invite links to threads
ClosedPublic

Authored by tomek on Jun 7 2024, 1:24 PM.
Tags
None
Referenced Files
F3381533: D12354.diff
Thu, Nov 28, 5:26 AM
Unknown Object (File)
Sun, Nov 24, 2:33 PM
Unknown Object (File)
Sun, Nov 24, 2:30 PM
Unknown Object (File)
Sun, Nov 24, 12:30 PM
Unknown Object (File)
Tue, Nov 12, 3:46 PM
Unknown Object (File)
Tue, Nov 12, 3:29 PM
Unknown Object (File)
Fri, Nov 1, 11:51 AM
Unknown Object (File)
Fri, Nov 1, 11:51 AM
Subscribers

Details

Summary

Check if the viewer can manage links in a thread (all the permissions pass for a script viewer). Modify the SQL scripts so that new columns are populated.
Didn't change the response from the server because we don't plan to create thread invite links from clients, and we can cut the complexity here (we don't need to deal with old clients).

https://linear.app/comm/issue/ENG-8387/modify-link-creation-logic-to-support-links-to-threads

Depends on D12351

Test Plan

Checked if creating and editing community links still work. Created a script which creates a thread link and checked if it works correctly - making this script work required some hacks https://linear.app/comm/issue/ENG-8390/fix-creating-invite-links-from-scrips.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage