Page MenuHomePhabricator
Differential D12351

[keyserver] Add a thread column to invite links
ClosedPublic
Actions

Authored by tomek on Jun 7 2024, 7:25 AM.
Tags
None
Referenced Files
F3361232: D12351.id41108.diff
Sun, Nov 24, 3:53 PM
F3361219: D12351.id41110.diff
Sun, Nov 24, 3:49 PM
F3361176: D12351.id41321.diff
Sun, Nov 24, 3:37 PM
Unknown Object (File)
Fri, Nov 22, 5:01 AM
Unknown Object (File)
Fri, Nov 1, 11:51 AM
Unknown Object (File)
Fri, Nov 1, 11:51 AM
Unknown Object (File)
Fri, Nov 1, 11:51 AM
Unknown Object (File)
Fri, Nov 1, 11:51 AM
View All 78 Files
Subscribers
ashoat

Details

Reviewers
inka
ginsu
Commits
rCOMM4c41696fb864: [keyserver] Add a thread column to invite links
Summary

This column is used to support links to chats

https://linear.app/comm/issue/ENG-8248/modify-invite-links-table-on-keyserver-to-include-an-optional-thread

Test Plan

Run the migration and check if the column was added. Create an empty DB and check if the column was created.
Also, checked if the index was created in both cases.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jun 7 2024, 7:25 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 7 2024, 7:25 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 7 2024, 7:36 AM
Harbormaster failed remote builds in B29531: Diff 41107!
tomek updated this revision to Diff 41108.Jun 7 2024, 8:22 AM

Add index

tomek edited the test plan for this revision. (Show Details)Jun 7 2024, 8:31 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 7 2024, 8:32 AM
Harbormaster failed remote builds in B29532: Diff 41108!
tomek updated this revision to Diff 41110.Jun 7 2024, 9:03 AM

Add roles column

Harbormaster completed remote builds in B29534: Diff 41110.Jun 7 2024, 9:25 AM
tomek requested review of this revision.Jun 7 2024, 9:25 AM
tomek updated this revision to Diff 41115.Jun 7 2024, 11:29 AM

Default null

Harbormaster completed remote builds in B29536: Diff 41115.Jun 7 2024, 11:46 AM
tomek added a child revision: D12354: [keyserver] Extend link creation logic to support invite links to threads.Jun 7 2024, 1:24 PM
ginsu accepted this revision.Jun 9 2024, 11:13 PM
This revision is now accepted and ready to land.Jun 9 2024, 11:13 PM
Closed by commit rCOMM4c41696fb864: [keyserver] Add a thread column to invite links (authored by tomek). · Explain WhyJun 14 2024, 5:27 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM4c41696fb864: [keyserver] Add a thread column to invite links.

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
10 lines
7 lines

Diff 41321

View Options

keyserver/src/database/migration-config.js

Loading...
View Options

keyserver/src/database/setup-db.js

Loading...