Page MenuHomePhabricator
Differential D12295

[lib] Pull `baseThreadIsWithBlockedUserOnly` out of `baseThreadIsWithBlockedUserOnly[WithoutAdminRoleCheck]`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 12:28 PM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Thu, Mar 6, 7:30 AM
Unknown Object (File)
Jan 19 2025, 9:34 AM
Unknown Object (File)
Dec 21 2024, 4:00 PM
View All 75 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMM48530a39381e: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of…
Summary

Pull common logic out of the two functions to reduce duplication and make things more readable.

Depends on D12294

Test Plan

flow + close reading, should be super simple refactor.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12295 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
55 lines

Diff 41418

View Options

lib/shared/thread-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
preparePushNotifs, preparePushNotifs,
type PerUserNotifBuildResult, type PerUserTargetedNotifications,
} from './send-utils.js'; } from './send-utils.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import { NeynarClientContext } from '../components/neynar-client-provider.react.js'; import { NeynarClientContext } from '../components/neynar-client-provider.react.js';
import type { MessageData } from '../types/message-types.js'; import type { MessageData } from '../types/message-types.js';
import type {
EncryptedNotifUtilsAPI,
SenderDeviceDescriptor,
} from '../types/notif-types.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function usePreparePushNotifs(): ( function usePreparePushNotifs(): (
encryptedNotifsUtilsAPI: EncryptedNotifUtilsAPI,
senderDeviceDescriptor: SenderDeviceDescriptor,
messageDatas: $ReadOnlyArray<MessageData>, messageDatas: $ReadOnlyArray<MessageData>,
) => Promise<?PerUserNotifBuildResult> { ) => Promise<?PerUserTargetedNotifications> {
const rawMessageInfos = useSelector(state => state.messageStore.messages); const rawMessageInfos = useSelector(state => state.messageStore.messages);
const rawThreadInfos = useSelector(state => state.threadStore.threadInfos); const rawThreadInfos = useSelector(state => state.threadStore.threadInfos);
const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos); const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos);
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const { getENSNames } = React.useContext(ENSCacheContext); const { getENSNames } = React.useContext(ENSCacheContext);
const getFCNames = React.useContext(NeynarClientContext)?.getFCNames; const getFCNames = React.useContext(NeynarClientContext)?.getFCNames;
return React.useCallback( return React.useCallback(
(messageDatas: $ReadOnlyArray<MessageData>) => { (
encryptedNotifUtilsAPI: EncryptedNotifUtilsAPI,
senderDeviceDescriptor: SenderDeviceDescriptor,
messageDatas: $ReadOnlyArray<MessageData>,
) => {
return preparePushNotifs({ return preparePushNotifs({
encryptedNotifUtilsAPI,
senderDeviceDescriptor,
messageInfos: rawMessageInfos, messageInfos: rawMessageInfos,
rawThreadInfos, rawThreadInfos,
auxUserInfos, auxUserInfos,
messageDatas, messageDatas,
userInfos, userInfos,
getENSNames, getENSNames,
getFCNames, getFCNames,
}); });
Show All 13 Lines