Page MenuHomePhabricator

[web] update QR login flow to use `QRAuthContext`
ClosedPublic

Authored by kamil on Jun 17 2024, 3:55 AM.
Tags
None
Referenced Files
F3365237: D12450.id41499.diff
Mon, Nov 25, 7:00 AM
Unknown Object (File)
Fri, Nov 1, 1:47 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Aug 29 2024, 6:11 PM
Subscribers

Details

Summary

ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

Rendering context and de-duplicating logic.

Depends on D12449

Test Plan

Test QR login flow on web. Adding a bunch of logs to make sure it works and all messages are sent.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable