Page MenuHomePhabricator

[native] remove `useQRAuth` hook
ClosedPublic

Authored by kamil on Jun 17 2024, 4:05 AM.
Tags
None
Referenced Files
F3383751: D12453.id41510.diff
Thu, Nov 28, 5:32 PM
F3383703: D12453.id41501.diff
Thu, Nov 28, 5:22 PM
Unknown Object (File)
Mon, Nov 25, 2:27 AM
Unknown Object (File)
Mon, Nov 25, 12:42 AM
Unknown Object (File)
Fri, Nov 1, 1:47 PM
Unknown Object (File)
Oct 21 2024, 1:53 AM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Unknown Object (File)
Oct 12 2024, 12:01 PM
Subscribers

Details

Summary

ENG-8385.

QR code login is not working right now. As described here (Point 3) and here the issue is occuring because of the fact that useQRAuth is unmounting before it can send SECONDARY_DEVICE_REGISTRATION_SUCCESS. This stack is refactoring the code to move logic to context (see here).

Moving this code to a context - reduces some complexity.

Depends on D12452

Test Plan

Test QR login flow on native and web. Adding a bunch of logs to make sure it works and all messages are sent.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable