Page MenuHomePhabricator
Differential D12508

[backup] Use authenticated service trait
ClosedPublic
Actions

Authored by bartek on Jun 20 2024, 2:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 7:21 PM
Unknown Object (File)
Mon, Dec 16, 7:21 PM
Unknown Object (File)
Mon, Dec 16, 7:21 PM
Unknown Object (File)
Mon, Dec 16, 7:21 PM
Unknown Object (File)
Mon, Dec 16, 7:06 PM
Unknown Object (File)
Fri, Dec 13, 1:41 PM
Unknown Object (File)
Nov 23 2024, 11:45 AM
Unknown Object (File)
Nov 16 2024, 9:38 AM
View All 60 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMM27ffa8ebee7c: [backup] Use authenticated service trait
Summary

Implemented the trait introduced in D12507 for BlobServiceClient and used it in backup handlers.
This simplifies the code and makes it more flexible and future-proof.

Depends on D12507

Test Plan

Tested backup service locally - blob requests are successful for both authenticated and unauthenticated HTTP endpoints

Diff Detail

Repository
rCOMM Comm
Branch
barthap/dns
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 20 2024, 2:35 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 2:35 AM
bartek mentioned this in D12507: [comm-lib][reports] Extract 'authenticated' service trait.Jun 20 2024, 2:36 AM
Harbormaster failed remote builds in B29813: Diff 41546!Jun 20 2024, 2:59 AM
bartek updated this revision to Diff 41549.Jun 20 2024, 3:26 AM

Rebase. Remove unused imports

Harbormaster completed remote builds in B29816: Diff 41549.Jun 20 2024, 3:42 AM
bartek published this revision for review.Jun 20 2024, 4:51 AM
bartek added a child revision: D12511: [backup][backup-client] Add auth to logs websocket.Jun 20 2024, 4:56 AM
kamil accepted this revision.Jun 21 2024, 4:03 AM
This revision is now accepted and ready to land.Jun 21 2024, 4:03 AM
Closed by commit rCOMM27ffa8ebee7c: [backup] Use authenticated service trait (authored by bartek). · Explain WhyJun 26 2024, 1:51 AM
This revision was automatically updated to reflect the committed changes.
bartek mentioned this in rCOMM141c4d1346de: [comm-lib][reports] Extract 'authenticated' service trait.
bartek added a commit: rCOMM27ffa8ebee7c: [backup] Use authenticated service trait.
kamil mentioned this in D12576: [native] remove call to setCommServicesAuthMetadata.Jun 27 2024, 2:25 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
http/
handlers/
33 lines
shared/
comm-lib/
src/
blob/
10 lines

Diff 41549

View Options

services/backup/src/http/handlers/backup.rs

Loading...
View Options

shared/comm-lib/src/blob/client.rs

Loading...