[lib][web][native] set local Tunnelbroker device token on client
ClosedPublic
Actions

Authored by kamil on Fri, Jun 21, 2:19 AM.

Details

Reviewers

bartek
marcin
inka

Commits

rCOMMec67fc69940a: [lib][web][native] set local Tunnelbroker device token on client

Summary

ENG-8400 and ENG-8348.

Discussed this with @inka, and we think it makes the most sense. The alternative is adding a new redux action only to set localToken and dispatch it whenever dispatching setDeviceTokenActionTypes.

Depends on D12527

Test Plan

On web make sure that on each refresh device token is set
On native make sure that on app open device token is set, on logout remains the same

Diff Detail

Repository

rCOMM Comm

Branch

device-token

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Fri, Jun 21, 2:19 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Jun 21, 2:19 AM

kamil added a child revision: D12537: [lib] introduce setting Tunnelbroker device token action.Fri, Jun 21, 2:33 AM

Harbormaster completed remote builds in B29863: Diff 41598.Fri, Jun 21, 2:41 AM

kamil published this revision for review.Fri, Jun 21, 2:46 AM

kamil edited the summary of this revision. (Show Details)

inka accepted this revision.Fri, Jun 21, 3:27 AM

This revision is now accepted and ready to land.Fri, Jun 21, 3:27 AM

Closed by commit rCOMMec67fc69940a: [lib][web][native] set local Tunnelbroker device token on client (authored by kamil). · Explain WhyFri, Jun 28, 7:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMec67fc69940a: [lib][web][native] set local Tunnelbroker device token on client.

ashoat added inline comments.Mon, Jul 1, 1:35 PM

lib/reducers/tunnelbroker-device-token-reducer.js
12–14 ↗	(On Diff #41810)	This pattern is confusing to me... in which cases do we expect `action.payload` to not be set? Is there a clearer way to differentiate between these two cases, eg. something like: type SetDeviceTokenStartedPayload = \| { +type: 'nothing_to_set' } \| { +type: 'optimistically_set_device_token', +deviceToken: string } \| { +type: 'clear_device_token' };
native/push/push-handler.react.js
536 ↗	(On Diff #41810)