Page MenuHomePhabricator
Differential D12741

[lib] Process DMOperations when received from peers via Tunnelbroker
ClosedPublic
Actions

Authored by ashoat on Jul 14 2024, 6:17 PM.
Tags
None
Referenced Files
F2719408: D12741.diff
Mon, Sep 16, 12:55 PM
F2719120: D12741.id42621.diff
Mon, Sep 16, 11:52 AM
F2715396: D12741.id42275.diff
Mon, Sep 16, 3:16 AM
F2715395: D12741.id42274.diff
Mon, Sep 16, 3:16 AM
Unknown Object (File)
Sun, Sep 15, 12:37 PM
Unknown Object (File)
Sun, Sep 15, 10:07 AM
Unknown Object (File)
Sun, Sep 15, 10:05 AM
Unknown Object (File)
Sat, Sep 14, 4:13 PM
View All 67 Files
Subscribers
tomek

Details

Reviewers
tomek
kamil
marcin
Commits
rCOMM2549b6da2a11: [lib] Process DMOperations when received from peers via Tunnelbroker
Summary

This is part of addressing ENG-8425.

I'll submit a follow-up diff that introduces a new action here to process the resultant data we receive.

Submitting this now so @tomek can see the code, as his work relates to this code.

Test Plan

Test plan described here

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/dmop
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jul 14 2024, 6:17 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2024, 6:31 PM
Harbormaster failed remote builds in B30314: Diff 42274!
ashoat updated this revision to Diff 42275.Jul 14 2024, 7:38 PM

ESLint fix

Harbormaster completed remote builds in B30315: Diff 42275.Jul 14 2024, 7:55 PM
ashoat requested review of this revision.Jul 14 2024, 7:55 PM
ashoat edited parent revisions, added: D12762: [SQLite] Query for latest edit in getLatestMessageEdit; removed: D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.Jul 15 2024, 2:26 PM
ashoat removed a parent revision: D12762: [SQLite] Query for latest edit in getLatestMessageEdit.Jul 15 2024, 7:05 PM
ashoat added a child revision: D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults.
ashoat removed a child revision: D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults.
ashoat added a parent revision: D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults.
ashoat edited the summary of this revision. (Show Details)
ashoat edited parent revisions, added: D12740: [lib] Introduce getRelatedMessages to SQLiteAPI; removed: D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults.
ashoat edited parent revisions, added: D12764: [lib] Introduce useGetLatestMessageEdit; removed: D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.Jul 15 2024, 7:38 PM
ashoat updated this revision to Diff 42315.Jul 15 2024, 7:39 PM

Rebase to rely on D12764

Harbormaster failed remote builds in B30353: Diff 42315!Jul 15 2024, 7:53 PM
ashoat updated this revision to Diff 42320.Jul 15 2024, 7:59 PM

Rebase

Harbormaster failed remote builds in B30358: Diff 42320!Jul 15 2024, 8:59 PM
ashoat updated this revision to Diff 42337.Jul 16 2024, 4:11 AM

Rebase

Harbormaster completed remote builds in B30374: Diff 42337.Jul 16 2024, 4:43 AM
ashoat added a child revision: D12780: [lib] Introduce new PROCESS_DM_OPS action and dispatch from useProcessDMOperation.Jul 16 2024, 8:07 PM
ashoat edited the test plan for this revision. (Show Details)Jul 21 2024, 10:16 PM
tomek accepted this revision.Jul 22 2024, 1:27 AM
This revision is now accepted and ready to land.Jul 22 2024, 1:27 AM
Closed by commit rCOMM2549b6da2a11: [lib] Process DMOperations when received from peers via Tunnelbroker (authored by ashoat). · Explain WhyJul 22 2024, 9:29 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM2549b6da2a11: [lib] Process DMOperations when received from peers via Tunnelbroker.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
34 lines
tunnelbroker/
8 lines
types/
7 lines
tunnelbroker/
16 lines

Diff 42337

View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/tunnelbroker/user-actions-peer-to-peer-message-types.js

Loading...