[tunnelbroker] Implement WebPush client adapter
ClosedPublic
Actions

Authored by bartek on Jul 26 2024, 6:22 AM.

Details

Reviewers

kamil
marcin

Commits

rCOMMdfc5114afe7f: [tunnelbroker] Implement WebPush client adapter

Summary

Implemented wrapper over web_push client, that handles VAPID signing and proper payload creation for us.
Configured it to use hyper backend, which is the same what we use for other push services (reqwest uses it under the hood).

Test Plan

Cargo build.
Tested together with the rest of the stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 26 2024, 6:22 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 26 2024, 6:22 AM

bartek added a child revision: D12894: [tunnelbroker] Implement sending WebPush notifs.Jul 26 2024, 6:24 AM

bartek published this revision for review.Jul 26 2024, 6:39 AM

bartek added inline comments.

services/tunnelbroker/src/notifs/web_push/mod.rs
14 ↗	(On Diff #42831)	We don't use the `config` anywhere outside `new()`, but I decided to keep it, for consistency with other push services.
15–16 ↗	(On Diff #42831)	Both are intended to be created once and cloned when used. HyperWebPushClient is generally expensive to create, but cheap to clone VapidSignatureBuilder can pre-compute some values once, basing on the private key. A full signature is then built separately for each request, when keys from SubscriptionInfo (device token) are supplied