Differential D12936

[lib] Create a new redux field to store the operations
ClosedPublic
Actions

Authored by tomek on Jul 30 2024, 2:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 12:45 PM

	Unknown Object (File)
	Mon, Nov 25, 12:42 PM

	Unknown Object (File)
	Mon, Nov 25, 10:52 AM

	Unknown Object (File)
	Thu, Nov 21, 1:37 AM

	Unknown Object (File)
	Thu, Nov 21, 1:37 AM

	Unknown Object (File)
	Wed, Nov 6, 11:33 PM

	Unknown Object (File)
	Wed, Nov 6, 11:33 PM

	Unknown Object (File)
	Wed, Nov 6, 10:34 PM

View All 80 Files

Subscribers

Details

Reviewers

kamil
inka

Commits

rCOMMeaa112928365: [lib] Create a new redux field to store the operations

Summary

When an operation can't be applied, we will store it in this queue.

https://linear.app/comm/issue/ENG-8764/create-a-new-redux-field-to-store-the-updates

Depends on D12921

Test Plan

Run the migrations and check if the store was created.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 30 2024, 2:47 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 2:47 AM

Harbormaster completed remote builds in B30787: Diff 42932.Jul 30 2024, 3:23 AM

tomek requested review of this revision.Jul 30 2024, 3:23 AM

tomek added a child revision: D12948: [lib] Add a function to DM operations spec checking if an operation can be applied.Jul 30 2024, 9:15 AM

inka accepted this revision.Jul 31 2024, 2:52 AM

inka added inline comments.

web/redux/persist-constants.js
6 ↗	(On Diff #42932)	Shouldn't the store versions match between platforms?

This revision is now accepted and ready to land.Jul 31 2024, 2:52 AM

tomek added inline comments.Jul 31 2024, 10:01 AM

web/redux/persist-constants.js
6 ↗	(On Diff #42932)	We're not there yet. At this point, the mismatch between versions doesn't matter. After we start supporting the backup, maintaining a parity between versions will become critical.

ashoat added a subscriber: atul.Aug 1 2024, 12:53 PM

ashoat added inline comments.

web/redux/persist-constants.js
6 ↗	(On Diff #42932)	Why not maintain this now? It seems weird that we started supporting it, but now are backtracking it (I guess it was broken by @atul's migration)

tomek added inline comments.Aug 2 2024, 12:49 AM

web/redux/persist-constants.js
6 ↗	(On Diff #42932)	From the code point of view, it doesn't matter. But we can do that as a good practice - going to update the diff.

Bump the version

Bump the version

Harbormaster completed remote builds in B30864: Diff 43031.Aug 2 2024, 2:40 AM

Harbormaster completed remote builds in B30863: Diff 43030.Aug 2 2024, 2:42 AM

Closed by commit rCOMMeaa112928365: [lib] Create a new redux field to store the operations (authored by tomek). · Explain WhyAug 2 2024, 8:38 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMeaa112928365: [lib] Create a new redux field to store the operations.

bartek mentioned this in D13402: [lib] Create Redux store for blob holders.Sep 20 2024, 3:47 AM

bartek mentioned this in rCOMMc714711fe073: [lib] Create Redux store for blob holders.Sep 23 2024, 7:24 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

6 lines

2 lines

utils/

reducers-utils.test.js

3 lines

native/

redux/

default-state.js

3 lines

11 lines

2 lines

web/

redux/

default-state.js

3 lines

handle-redux-migration-failure.js

1 line

persist-constants.js

2 lines

9 lines

2 lines

Diff 43049

lib/types/dm-ops.js

Loading...

lib/types/redux-types.js

Loading...

lib/utils/reducers-utils.test.js

Loading...

native/redux/default-state.js

Loading...

native/redux/persist.js

Loading...

native/redux/state-types.js

Loading...

web/redux/default-state.js

Loading...

web/redux/handle-redux-migration-failure.js

Loading...

web/redux/persist-constants.js

Loading...

web/redux/persist.js

Loading...

web/redux/redux-setup.js

Loading...