Page MenuHomePhabricator
Differential D13037

[native] empty bottom sheet for linked devices
ClosedPublic
Actions

Authored by varun on Aug 9 2024, 12:47 PM.
Tags
None
Referenced Files
F3335997: D13037.id43279.diff
Thu, Nov 21, 1:26 PM
F3335944: D13037.id43580.diff
Thu, Nov 21, 12:47 PM
F3335253: D13037.diff
Thu, Nov 21, 8:45 AM
Unknown Object (File)
Wed, Nov 13, 12:57 PM
Unknown Object (File)
Wed, Nov 13, 12:57 PM
Unknown Object (File)
Sat, Nov 9, 8:21 AM
Unknown Object (File)
Oct 22 2024, 10:44 AM
Unknown Object (File)
Oct 22 2024, 10:19 AM
View All 51 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
bartek
Commits
rCOMMd2ec3efd9b1d: [native] empty bottom sheet for linked devices
Summary

Depends on D12907

In the next diff, I will add a button to the bottom sheet that lets the user remove the selected secondary device

Test Plan

bottom sheet opens and closes properly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Aug 9 2024, 12:47 PM
varun added a child revision: D13038: [lib] rename PrimaryDeviceLogout -> DeviceLogout.Aug 9 2024, 1:01 PM
Harbormaster completed remote builds in B31027: Diff 43279.Aug 9 2024, 1:06 PM
varun requested review of this revision.Aug 9 2024, 1:06 PM
ashoat accepted this revision.Aug 10 2024, 2:41 PM
ashoat added inline comments.
native/profile/linked-devices-bottom-sheet.react.js
24–25 ↗(On Diff #43279)

Why do we have these two lines?

This revision is now accepted and ready to land.Aug 10 2024, 2:41 PM
Closed by commit rCOMMd2ec3efd9b1d: [native] empty bottom sheet for linked devices (authored by varun). · Explain WhyAug 22 2024, 9:24 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMd2ec3efd9b1d: [native] empty bottom sheet for linked devices.

Revision Contents
Changeset List

Diff 43580

View Options

native/navigation/root-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...
View Options

native/profile/linked-devices-bottom-sheet.react.js

Loading...
View Options

native/profile/linked-devices-list-item.react.js

Loading...