Page MenuHomePhabricator
Differential D13189

JSI to update unread thick thread IDs in MMKV
ClosedPublic
Actions

Authored by marcin on Aug 28 2024, 3:07 AM.
Tags
None
Referenced Files
F3301885: D13189.diff
Mon, Nov 18, 4:45 AM
Unknown Object (File)
Mon, Nov 11, 6:09 AM
Unknown Object (File)
Sun, Nov 10, 5:47 AM
Unknown Object (File)
Sun, Nov 10, 5:21 AM
Unknown Object (File)
Sun, Nov 10, 4:16 AM
Unknown Object (File)
Sun, Nov 10, 4:06 AM
Unknown Object (File)
Sun, Nov 10, 2:47 AM
Unknown Object (File)
Sun, Nov 10, 2:39 AM
View All 83 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM05f48bd31b3d: JSI to update unread thick thread IDs in MMKV
Summary

This differential implements JSI that allows to set and get unread thick thread IDs from MMKV from JS.

Test Plan

Tested in next diff

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-8243
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Aug 28 2024, 3:07 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 3:07 AM
marcin added a parent revision: D13188: Add method to set entire sttring set at once in MMKV.Aug 28 2024, 3:07 AM
marcin added a child revision: D13190: Update badge count from JS on native taking into account thick threads.Aug 28 2024, 3:13 AM
Harbormaster completed remote builds in B31319: Diff 43727.Aug 28 2024, 3:43 AM
marcin requested review of this revision.Aug 28 2024, 3:43 AM
tomek accepted this revision.Aug 29 2024, 6:11 AM
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
1489

Can we use a shared constant?

This revision is now accepted and ready to land.Aug 29 2024, 6:11 AM
marcin updated this revision to Diff 43837.Sep 2 2024, 9:04 AM

Share unread thick thread ids set key between C++, Java and Obj-C

marcin updated this revision to Diff 43840.Sep 2 2024, 9:08 AM

Remove remaining usage of hardcoded NOTIFS.UNREAD_THICK_THREADS constant in CommCoreModule.cpp

Harbormaster failed remote builds in B31392: Diff 43837!Sep 2 2024, 9:25 AM
Harbormaster failed remote builds in B31395: Diff 43840!Sep 2 2024, 9:51 AM
marcin updated this revision to Diff 43856.Sep 3 2024, 2:39 AM

Fix iOS compilation

Harbormaster completed remote builds in B31410: Diff 43856.Sep 3 2024, 2:56 AM
marcin updated this revision to Diff 43865.Sep 3 2024, 7:31 AM

Rebase before landing

Harbormaster completed remote builds in B31419: Diff 43865.Sep 3 2024, 8:03 AM
Closed by commit rCOMM05f48bd31b3d: JSI to update unread thick thread IDs in MMKV (authored by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhySep 3 2024, 8:20 AM
This revision was automatically updated to reflect the committed changes.
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMM05f48bd31b3d: JSI to update unread thick thread IDs in MMKV.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
5 lines
68 lines
_generated/
schema/
6 lines

Diff 43727

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...