Page MenuHomePhabricator
Differential D13195

[lib] remove `newMemberIDs` from `DMThreadSettingsChanges`
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 7:42 AM.
Tags
None
Referenced Files
F3356961: D13195.id43778.diff
Sat, Nov 23, 9:40 PM
F3356878: D13195.id43751.diff
Sat, Nov 23, 9:09 PM
Unknown Object (File)
Sun, Nov 17, 3:39 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 9:41 PM
View All 59 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
marcin
Commits
rCOMM92cd9357bc28: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges`
Summary

ENG-8979;

For adding new members there is separate spec, ADD_MEMBERS and ADD_VIEWER_TO_THREAD_MEMBERS.

Depends on D13192

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 28 2024, 7:42 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 7:42 AM
kamil edited the summary of this revision. (Show Details)Aug 28 2024, 7:43 AM
kamil added a parent revision: D13192: [lib] implement changing DM threads settings.
kamil published this revision for review.Aug 28 2024, 7:55 AM
Harbormaster completed remote builds in B31340: Diff 43751.Aug 28 2024, 7:59 AM
tomek accepted this revision.Aug 28 2024, 9:19 AM
tomek added inline comments.
lib/shared/dm-ops/change-thread-settings-spec.js
60 ↗(On Diff #43751)

This function could now be inlined in addMembersSpec.

154 ↗(On Diff #43751)

This can also be inlined.

lib/types/dm-ops.js
31–32 ↗(On Diff #43751)

This can be deleted.

281–299 ↗(On Diff #43751)

We can inline dmChangeThreadSettingsBaseValidatorShape into dmChangeThreadSettingsOperationValidator.

306–316 ↗(On Diff #43751)

We can delete these.

This revision is now accepted and ready to land.Aug 28 2024, 9:19 AM
kamil updated this revision to Diff 43778.Aug 29 2024, 12:20 AM

address review

Harbormaster completed remote builds in B31358: Diff 43778.Aug 29 2024, 12:40 AM
Closed by commit rCOMM92cd9357bc28: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges` (authored by kamil). · Explain WhyAug 29 2024, 1:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM92cd9357bc28: [lib] remove `newMemberIDs` from `DMThreadSettingsChanges`.

Revision Contents
Changeset List

Diff 43783

View Options

lib/actions/thread-actions.js

Loading...
View Options

lib/shared/dm-ops/add-members-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-settings-and-add-viewer-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-specs.js

Loading...
View Options

lib/types/dm-ops.js

Loading...