Page MenuHomePhabricator

[lib] Check the timestamps when updating thread subscription
ClosedPublic

Authored by tomek on Sep 3 2024, 9:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 12:09 AM
Unknown Object (File)
Sat, Nov 9, 4:21 PM
Unknown Object (File)
Sat, Nov 9, 2:48 PM
Unknown Object (File)
Sun, Nov 3, 10:30 PM
Unknown Object (File)
Wed, Oct 23, 7:30 PM
Unknown Object (File)
Tue, Oct 22, 6:29 PM
Unknown Object (File)
Fri, Oct 18, 5:16 PM
Unknown Object (File)
Fri, Oct 18, 5:16 PM
Subscribers

Details

Summary

Check the timestamp and don't update the subscription when the timestamp is more recent than the operation.

https://linear.app/comm/issue/ENG-9119/update-changethreadsubscriptionspec

Depends on D13233

Test Plan

Perform a couple of thread subscription operations and check if the state is correct.

Diff Detail

Repository
rCOMM Comm
Branch
timestamps
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 3 2024, 10:02 AM
Harbormaster failed remote builds in B31422: Diff 43877!
tomek requested review of this revision.Sep 3 2024, 10:15 AM
This revision is now accepted and ready to land.Sep 5 2024, 12:46 AM