Page MenuHomePhabricator
Differential D13234

[lib] Check the timestamps when updating thread subscription
ClosedPublic
Actions

Authored by tomek on Sep 3 2024, 9:58 AM.
Tags
None
Referenced Files
F3368545: D13234.id43938.diff
Mon, Nov 25, 8:11 PM
F3366241: D13234.diff
Mon, Nov 25, 10:19 AM
Unknown Object (File)
Sun, Nov 10, 12:09 AM
Unknown Object (File)
Sat, Nov 9, 4:21 PM
Unknown Object (File)
Sat, Nov 9, 2:48 PM
Unknown Object (File)
Sun, Nov 3, 10:30 PM
Unknown Object (File)
Oct 23 2024, 7:30 PM
Unknown Object (File)
Oct 22 2024, 6:29 PM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
marcin
Commits
rCOMM9ede5407abc5: [lib] Check the timestamps when updating thread subscription
Summary

Check the timestamp and don't update the subscription when the timestamp is more recent than the operation.

https://linear.app/comm/issue/ENG-9119/update-changethreadsubscriptionspec

Depends on D13233

Test Plan

Perform a couple of thread subscription operations and check if the state is correct.

Diff Detail

Repository
rCOMM Comm
Branch
timestamps
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Sep 3 2024, 9:58 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 3 2024, 9:58 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 3 2024, 10:02 AM
Harbormaster failed remote builds in B31422: Diff 43877!
Harbormaster completed remote builds in B31422: Diff 43877.Sep 3 2024, 10:15 AM
tomek requested review of this revision.Sep 3 2024, 10:15 AM
tomek added a child revision: D13240: [lib] Check the timestamps when updating read status.Sep 4 2024, 7:28 AM
tomek added a child revision: D13241: [lib] Check the timestamps when updating read status for all the specs.Sep 4 2024, 9:58 AM
marcin accepted this revision.Sep 5 2024, 12:46 AM
This revision is now accepted and ready to land.Sep 5 2024, 12:46 AM
tomek removed a child revision: D13240: [lib] Check the timestamps when updating read status.Sep 5 2024, 3:12 AM
Closed by commit rCOMM9ede5407abc5: [lib] Check the timestamps when updating thread subscription (authored by tomek). · Explain WhySep 6 2024, 8:10 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM9ede5407abc5: [lib] Check the timestamps when updating thread subscription.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
17 lines

Diff 43877

View Options

lib/shared/dm-ops/change-thread-subscription.js

Loading...