Check the timestamp and don't update the subscription when the timestamp is more recent than the operation.
https://linear.app/comm/issue/ENG-9119/update-changethreadsubscriptionspec
Depends on D13233
Paths
| Differential D13234 Authored by tomek on Sep 3 2024, 9:58 AM.
Tags None Referenced Files
Subscribers
Details Summary Check the timestamp and don't update the subscription when the timestamp is more recent than the operation. https://linear.app/comm/issue/ENG-9119/update-changethreadsubscriptionspec Depends on D13233 Test Plan Perform a couple of thread subscription operations and check if the state is correct.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptSep 3 2024, 9:58 AM2024-09-03 09:58:03 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Sep 3 2024, 10:02 AM2024-09-03 10:02:02 (UTC-7) Harbormaster completed remote builds in B31422: Diff 43877.Sep 3 2024, 10:15 AM2024-09-03 10:15:15 (UTC-7) This revision is now accepted and ready to land.Sep 5 2024, 12:46 AM2024-09-05 00:46:41 (UTC-7) tomek removed a child revision: D13240: [lib] Check the timestamps when updating read status.Sep 5 2024, 3:12 AM2024-09-05 03:12:19 (UTC-7) Closed by commit rCOMM9ede5407abc5: [lib] Check the timestamps when updating thread subscription (authored by tomek). · Explain WhySep 6 2024, 8:10 AM2024-09-06 08:10:51 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 43877 lib/shared/dm-ops/change-thread-subscription.js
|