Page MenuHomePhabricator
Differential D13219

[lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`
ClosedPublic
Actions

Authored by tomek on Sep 2 2024, 7:41 AM.
Tags
None
Referenced Files
F3197224: D13219.diff
Sat, Nov 9, 7:47 AM
Unknown Object (File)
Mon, Nov 4, 6:27 PM
Unknown Object (File)
Sun, Nov 3, 2:34 AM
Unknown Object (File)
Tue, Oct 22, 6:29 PM
Unknown Object (File)
Fri, Oct 18, 5:16 PM
Unknown Object (File)
Fri, Oct 18, 5:16 PM
Unknown Object (File)
Fri, Oct 18, 5:16 PM
Unknown Object (File)
Fri, Oct 18, 5:16 PM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`
Summary

When a user is added to a thread, they should get the correct timestamps instead of assuming that thread creation time or operation time are correct.

https://linear.app/comm/issue/ENG-9124/send-timestamps-in-existingthreaddetails

Depends on D13218

Test Plan

Create an operation with the creation of a new thread. Check if the timestamps are correct.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Sep 2 2024, 7:41 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 2 2024, 7:41 AM
tomek updated this revision to Diff 43832.Sep 2 2024, 7:42 AM

Merge imports

Harbormaster completed remote builds in B31386: Diff 43831.Sep 2 2024, 7:57 AM
Harbormaster completed remote builds in B31387: Diff 43832.
tomek requested review of this revision.Sep 2 2024, 7:58 AM
tomek added a child revision: D13220: [lib] Check the timestamps when leaving a thread.Sep 2 2024, 8:53 AM
inka accepted this revision.Sep 3 2024, 3:59 AM
This revision is now accepted and ready to land.Sep 3 2024, 3:59 AM
tomek mentioned this in D13218: [lib] Check the timestamps when adding the viewer to thread members.Sep 5 2024, 3:15 AM
tomek updated this revision to Diff 43892.Sep 5 2024, 3:25 AM

Pass timestamps directly to createThickRawThreadInfo

Harbormaster completed remote builds in B31434: Diff 43892.Sep 5 2024, 3:42 AM
Closed by commit rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput` (authored by tomek). · Explain WhySep 6 2024, 8:10 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM0f069ef7f861: [lib] Include `timestamps` inside `CreateThickRawThreadInfoInput`.

Revision Contents
Changeset List

Diff 43892

View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Loading...
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/types/dm-ops.js

Loading...