Only update the status when it is more recent than the saved timestamp.
https://linear.app/comm/issue/ENG-9112/handle-unread-status
Depends on D13234
Details
Details
Process a couple of operations with text messages and check if the unread status and timestamps are correct.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- timestamps
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/dm-ops/process-dm-ops.js | ||
|---|---|---|
| 247–275 ↗ | (On Diff #43885) | This is to satisfy Flow. |
| lib/shared/dm-ops/process-dm-ops.js | ||
|---|---|---|
| 199 ↗ | (On Diff #43939) | What's the context on this change? |
| lib/shared/dm-ops/process-dm-ops.js | ||
|---|---|---|
| 199 ↗ | (On Diff #43939) | When we process the operation, we create a map updatedThreadInfosByThreadID with the most recent thread infos. We need this map so that we can correctly create UPDATE_THREAD update that don't override changes made by the specs. UPDATE_THREAD update overrides completely a thread in the store, with its content. Before this diff, we were using UPDATE_THREAD to update the replies count, which was only affecting the sidebars - that's why this condition existed. For the unread status, we were using UPDATE_THREAD_READ_STATUS which doesn't override the thread and updates only one of its properties. In this diff, we're replacing UPDATE_THREAD_READ_STATUS with UPDATE_THREAD for all the other threads, which means that updatedThreadInfosByThreadID map has to include all the threads. |
| lib/shared/dm-ops/process-dm-ops.js | ||
|---|---|---|
| 199 ↗ | (On Diff #43939) | That makes sense – thanks for explaining! |