Page MenuHomePhabricator

[lib] Fix sendnig create_sidebar to peers
ClosedPublic

Authored by inka on Sep 6 2024, 6:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 2:18 AM
Unknown Object (File)
Fri, Jan 3, 8:09 AM
Unknown Object (File)
Fri, Dec 27, 1:42 AM
Unknown Object (File)
Fri, Dec 27, 1:41 AM
Unknown Object (File)
Fri, Dec 27, 1:41 AM
Unknown Object (File)
Fri, Dec 27, 1:39 AM
Unknown Object (File)
Sun, Dec 22, 5:40 PM
Unknown Object (File)
Sun, Dec 22, 5:21 PM
Subscribers

Details

Summary

issue: ENG-9134
For sidebars we should also inform the members of the parent about thier creation

Test Plan

Tested that now when a sidebar is created in a thick thread, other members of the thick thread are informed

Diff Detail

Repository
rCOMM Comm
Branch
inka/thread_ops
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Sep 6 2024, 7:14 AM
tomek added inline comments.
lib/hooks/thread-search-hooks.js
114

How about renaming it?

134–138

We shouldn't include the members here - they are already included in the parent thread's members list.

This revision is now accepted and ready to land.Sep 6 2024, 7:43 AM
This revision was automatically updated to reflect the committed changes.