Page MenuHomePhabricator

[lib] Introduce thread timestamps on the JS side
ClosedPublic

Authored by tomek on Aug 30 2024, 9:07 AM.
Tags
None
Referenced Files
F3197248: D13214.id43930.diff
Sat, Nov 9, 7:50 AM
F3197229: D13214.id43820.diff
Sat, Nov 9, 7:49 AM
Unknown Object (File)
Sun, Nov 3, 9:26 PM
Unknown Object (File)
Sun, Nov 3, 9:26 PM
Unknown Object (File)
Sun, Nov 3, 9:25 PM
Unknown Object (File)
Sun, Nov 3, 9:25 PM
Unknown Object (File)
Sun, Nov 3, 2:34 AM
Unknown Object (File)
Sat, Oct 26, 3:41 AM
Subscribers

Details

Summary

Create a new property with the timestamps. All the new thick threads will have it. We don't really need to have a migration introducing them, because all the thick threads we have were created by code on dev environments.

https://linear.app/comm/issue/ENG-8751/add-a-timestamps-property-to-a-thick-thread-info

Depends on D13211

Test Plan

On native and web, create a new thick thread, check if it contains the timestamps. Restart the apps and check if the timestamps are still there.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove replies count timestamp - the replies count is based on the messages which means it doesn't need a timestamp.

tomek requested review of this revision.Aug 30 2024, 9:47 AM
This revision is now accepted and ready to land.Sep 3 2024, 3:06 AM
lib/types/thread-types.js
152 ↗(On Diff #43827)

What is this representing?

lib/types/thread-types.js
152 ↗(On Diff #43827)

It represents the last change of the unread status.