Page MenuHomePhabricator
Differential D13233

[lib] Check the timestamps when removing thread members
ClosedPublic
Actions

Authored by tomek on Sep 3 2024, 7:17 AM.
Tags
None
Referenced Files
F3361639: D13233.diff
Sun, Nov 24, 6:35 PM
Unknown Object (File)
Sat, Nov 9, 11:50 PM
Unknown Object (File)
Sat, Nov 9, 4:20 PM
Unknown Object (File)
Sat, Nov 9, 2:45 PM
Unknown Object (File)
Oct 22 2024, 6:29 PM
Unknown Object (File)
Oct 18 2024, 5:16 PM
Unknown Object (File)
Oct 18 2024, 5:16 PM
Unknown Object (File)
Oct 16 2024, 3:28 PM
View All 35 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMff656da6fda9: [lib] Check the timestamps when removing thread members
Summary

Check the timestamp and don't remove members when the timestamp is more recent than the operation.

https://linear.app/comm/issue/ENG-9117/update-removemembersspec

Depends on D13220

Test Plan

Perform a couple of remove and add members operations and check if the membership and timestamps are correct.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
27 lines

Diff 43937

View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...