[native] Fix UsernameSelection loading state when usingCommServicesAccessToken
ClosedPublic
Actions

Authored by ashoat on Sep 12 2024, 11:09 AM.

Details

Reviewers

varun
will

Commits

rCOMM1eeff55c6c77: [native] Fix UsernameSelection loading state when usingCommServicesAccessToken

Summary

@varun didn't consider loading state in D11320, so it was broken when usingCommServicesAccessToken.

Depends on D13310

Test Plan

Make sure loading state works correctly in UsernameSelection

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 12 2024, 11:09 AM

Herald added a subscriber: tomek. · View Herald TranscriptSep 12 2024, 11:09 AM

ashoat added a child revision: D13312: [native] Fix Comm swoosh render in RegistrationTerms on iOS release builds.Sep 12 2024, 11:10 AM

Harbormaster completed remote builds in B31578: Diff 44111.Sep 12 2024, 11:25 AM

ashoat requested review of this revision.Sep 12 2024, 11:25 AM

varun accepted this revision.Sep 13 2024, 5:15 AM

This revision is now accepted and ready to land.Sep 13 2024, 5:15 AM

Closed by commit rCOMM1eeff55c6c77: [native] Fix UsernameSelection loading state when usingCommServicesAccessToken (authored by ashoat). · Explain WhySep 13 2024, 7:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1eeff55c6c77: [native] Fix UsernameSelection loading state when usingCommServicesAccessToken.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

username-selection.react.js

44 lines

Diff 44111

View Options

native/account/registration/username-selection.react.js

[native] Fix UsernameSelection loading state when usingCommServicesAccessTokenClosedPublicActions