Page MenuHomePhabricator

[web][native] Update UI to not display GENESIS over thick threads
ClosedPublic

Authored by inka on Sep 13 2024, 3:11 AM.
Tags
None
Referenced Files
F3517605: D13320.id44187.diff
Sun, Dec 22, 5:54 PM
F3517547: D13320.id44124.diff
Sun, Dec 22, 5:44 PM
F3517420: D13320.id44171.diff
Sun, Dec 22, 5:17 PM
F3516142: D13320.diff
Sun, Dec 22, 12:27 PM
Unknown Object (File)
Mon, Dec 16, 5:10 AM
Unknown Object (File)
Fri, Dec 13, 6:33 PM
Unknown Object (File)
Nov 14 2024, 1:01 PM
Unknown Object (File)
Nov 14 2024, 12:59 PM
Subscribers
None

Details

Diff Detail

Repository
rCOMM Comm
Branch
inka/GENESIS_UI
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka edited the test plan for this revision. (Show Details)EditedSep 13 2024, 3:12 AM

I changed some things compared to what we discussed on linear: I updated spacing, and changed the color of the icon on web to match breadcrumbs

web/chat/chat-thread-list.css
297

Text is 18px high, and has padding padding: 8px 0 2px 0;. The icon is 19px high. I wanted the text and icon to be more or less aligned

inka requested review of this revision.Sep 13 2024, 3:28 AM
tomek added inline comments.
native/chat/chat-thread-list-item.react.js
154–158

I don't think the memoization is beneficial here.

This revision is now accepted and ready to land.Sep 13 2024, 3:55 AM