Tags

None

Referenced Files

	F3538580: D13350.id44256.diff
	Wed, Dec 25, 11:08 PM

	F3538280: D13350.id44204.diff
	Wed, Dec 25, 10:36 PM

	Unknown Object (File)
	Sun, Dec 22, 9:39 PM

	Unknown Object (File)
	Sun, Dec 22, 9:39 PM

	Unknown Object (File)
	Sun, Dec 22, 9:39 PM

	Unknown Object (File)
	Sun, Dec 22, 9:39 PM

	Unknown Object (File)
	Nov 20 2024, 7:02 AM

	Unknown Object (File)
	Nov 20 2024, 6:39 AM

View All 39 Files

Subscribers

None

Details

Reviewers

marcin
ashoat
tomek

Commits

rCOMM264bde56ab4a: [native][web] use tunnelbroker for online status of thick threaded entries…

Summary

Entry online status shouldn't be decided by keyserver for thick threaded entries. We're changing it to use tunnelbroker status instead

Depends on D13349

Test Plan

console logged on native. Will figure out how to test this on web

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Sep 16 2024, 1:36 AM

Harbormaster completed remote builds in B31632: Diff 44204.Sep 16 2024, 2:19 AM

will requested review of this revision.Sep 16 2024, 2:19 AM

tomek accepted this revision.Sep 16 2024, 5:55 AM

This revision is now accepted and ready to land.Sep 16 2024, 5:55 AM

Seems like some copy-paste here that could be factored out

will added a child revision: D13354: [web] Disable thick thread entries from showing up in the history modal as history entries.Sep 16 2024, 1:20 PM

Closed by commit rCOMM264bde56ab4a: [native][web] use tunnelbroker for online status of thick threaded entries… (authored by will). · Explain WhySep 16 2024, 2:27 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM264bde56ab4a: [native][web] use tunnelbroker for online status of thick threaded entries….

In D13350#376127, @ashoat wrote:

Seems like some copy-paste here that could be factored out

created an issue https://linear.app/comm/issue/ENG-9306/reduce-code-duplication-in-setting-entry-online-status

[native][web] use tunnelbroker for online status of thick threaded entries instead of keyserver
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 44204

native/calendar/entry.react.js

web/calendar/entry.react.js

[native][web] use tunnelbroker for online status of thick threaded entries instead of keyserverClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44204

native/calendar/entry.react.js

web/calendar/entry.react.js

[native][web] use tunnelbroker for online status of thick threaded entries instead of keyserver
ClosedPublic
Actions

Revision Contents
Changeset List