[keyserver][lib] Update raw entry info to be thick or thin
ClosedPublic
Actions

Authored by will on Sep 13 2024, 5:26 AM.

Details

Reviewers

Commits

Summary

This updates raw entry info to be union type of either thick or thin.

Test Plan

flow check. Will test later in stack

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

will requested review of this revision.Sep 13 2024, 5:43 AM

tomek added inline comments.

lib/types/entry-types.js
37 ↗	(On Diff #44115)	Should this be mandatory for thick threads?
51–53 ↗	(On Diff #44115)
63 ↗	(On Diff #44115)	Looks like it is always true.

This revision is now accepted and ready to land.Sep 13 2024, 10:02 AM

lib/types/entry-types.js
37 ↗	(On Diff #44115)	Agree – we can move this out of the base, and have it be `t.maybe` for thin and always defined for thick
38 ↗	(On Diff #44115)	Do we need `localID` for thick?
63 ↗	(On Diff #44115)	We can use `tBool(true)`

lib/types/entry-types.js
38 ↗	(On Diff #44115)	Seemingly not? We seemingly use it for optimistic creations before it gets assigned a serverID on the keyserver. I imagine this doesn't really apply in client to client?

review feedback

lib/types/entry-types.js
26 ↗	(On Diff #44236)	I thought we agreed we didn't need this in the base
37 ↗	(On Diff #44236)	I thought we agreed we didn't need this in the base

This revision was automatically updated to reflect the committed changes.

lib/types/entry-types.js
26 ↗	(On Diff #44236)	addressing in https://linear.app/comm/issue/ENG-9303/remove-localid-from-rawentryinfobase
37 ↗	(On Diff #44236)	Addressing in https://linear.app/comm/issue/ENG-9303/remove-localid-from-rawentryinfobase