Differential D13350

[native][web] use tunnelbroker for online status of thick threaded entries instead of keyserver
ClosedPublic
Actions

Authored by will on Sep 16 2024, 1:36 AM.

Tags

None

Referenced Files

	F3197424: D13350.diff
	Sat, Nov 9, 8:31 AM

	Unknown Object (File)
	Thu, Nov 7, 1:48 PM

	Unknown Object (File)
	Thu, Nov 7, 1:26 PM

	Unknown Object (File)
	Wed, Oct 23, 9:11 AM

	Unknown Object (File)
	Wed, Oct 23, 9:11 AM

	Unknown Object (File)
	Fri, Oct 18, 10:23 PM

	Unknown Object (File)
	Fri, Oct 18, 1:58 PM

	Unknown Object (File)
	Oct 5 2024, 3:25 PM

View All 29 Files

Subscribers

None

Details

Reviewers

marcin
ashoat
tomek

Commits

rCOMM264bde56ab4a: [native][web] use tunnelbroker for online status of thick threaded entries…

Summary

Entry online status shouldn't be decided by keyserver for thick threaded entries. We're changing it to use tunnelbroker status instead

Depends on D13349

Test Plan

console logged on native. Will figure out how to test this on web

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Sep 16 2024, 1:36 AM

Harbormaster completed remote builds in B31632: Diff 44204.Sep 16 2024, 2:19 AM

will requested review of this revision.Sep 16 2024, 2:19 AM

tomek accepted this revision.Sep 16 2024, 5:55 AM

This revision is now accepted and ready to land.Sep 16 2024, 5:55 AM

Seems like some copy-paste here that could be factored out

will added a child revision: D13354: [web] Disable thick thread entries from showing up in the history modal as history entries.Sep 16 2024, 1:20 PM

Closed by commit rCOMM264bde56ab4a: [native][web] use tunnelbroker for online status of thick threaded entries… (authored by will). · Explain WhySep 16 2024, 2:27 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM264bde56ab4a: [native][web] use tunnelbroker for online status of thick threaded entries….

In D13350#376127, @ashoat wrote:

Seems like some copy-paste here that could be factored out

created an issue https://linear.app/comm/issue/ENG-9306/reduce-code-duplication-in-setting-entry-online-status

Revision Contents
Changeset List

Path

Size

native/

calendar/

11 lines

web/

calendar/

10 lines

Diff 44256

native/calendar/entry.react.js

Loading...

web/calendar/entry.react.js

Loading...