Page MenuHomePhabricator

[lib] Add reducer and action to store established holder
AcceptedPublic

Authored by bartek on Fri, Sep 20, 3:52 AM.
Tags
None
Referenced Files
F2786490: D13403.id44361.diff
Sat, Sep 21, 12:50 AM
F2786238: D13403.diff
Fri, Sep 20, 10:52 PM
F2784983: D13403.id.diff
Fri, Sep 20, 7:01 PM
F2784448: D13403.diff
Fri, Sep 20, 6:31 PM
F2782943: D13403.id44361.diff
Fri, Sep 20, 4:40 PM
F2781217: D13403.id.diff
Fri, Sep 20, 2:48 PM
F2781018: D13403.diff
Fri, Sep 20, 2:36 PM
F2779266: D13403.id44361.diff
Fri, Sep 20, 10:07 AM
Subscribers

Details

Reviewers
kamil
tomek
Summary

First action from ENG-9285. Addresses ENG-9286.

Added reducer for holders and action to store already-established holder in the store.
We use it in the blob service upload hook, to store the initial holder, which previously was forgotten

Inspired by D12949

Depends on D13401, D13402

Test Plan
  • Reducer unit test
  • Uploaded multimedia to a DM thread and used Redux Devtools to ensure the action was performed correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Fri, Sep 20, 4:20 AM
lib/actions/upload-actions.js
155–158

Why isn't this type read-only?

kamil added inline comments.
lib/reducers/holder-reducer.js
17

Is it possible to have this holder in store already?

lib/reducers/holder-reducer.test.js
23

nice

This revision is now accepted and ready to land.Fri, Sep 20, 6:08 AM