Page MenuHomePhabricator
Differential D13413

[lib] Create holder ops for thick thread avatars
ClosedPublic
Actions

Authored by bartek on Fri, Sep 20, 6:42 AM.
Tags
None
Referenced Files
F3012512: D13413.id44384.diff
Sat, Oct 19, 3:33 AM
Unknown Object (File)
Tue, Oct 15, 10:51 PM
Unknown Object (File)
Sat, Oct 12, 12:35 AM
Unknown Object (File)
Tue, Oct 8, 3:38 PM
Unknown Object (File)
Mon, Oct 7, 1:47 PM
Unknown Object (File)
Sat, Oct 5, 3:33 PM
Unknown Object (File)
Sat, Oct 5, 9:20 AM
Unknown Object (File)
Thu, Oct 3, 6:07 PM
View All 30 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM7ab6657dfa3c: [lib] Create holder ops for thick thread avatars
Summary

Added blob holder operations when changing thick thread avatars.

We want to:

  • Always remove a holder if the old avatar was image
  • Establish holder if the new avatar is image. We want it only for inbound ops. For outbound, the holder is already established during image upload.

Depends on D13411

Test Plan

Created a DM thread with two devices.

  • Set avatar to image on device A. Only device B generated op to establish holder.
  • Changed avatar to another image. Both devices generated op to remove avatar. Only inbound device established holder.
  • Reset avatar to emoji. Both devices removed their avatars

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Fri, Sep 20, 6:42 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 20, 6:42 AM
bartek mentioned this in D13411: [lib] Process blob holders in DM ops.Fri, Sep 20, 6:42 AM
bartek updated this revision to Diff 44381.Fri, Sep 20, 6:47 AM

Rebase

bartek updated this revision to Diff 44384.Fri, Sep 20, 6:57 AM

Rebase

Harbormaster failed remote builds in B31742: Diff 44378!Fri, Sep 20, 6:58 AM
Harbormaster failed remote builds in B31745: Diff 44381!Fri, Sep 20, 7:05 AM
bartek published this revision for review.Fri, Sep 20, 7:09 AM
Harbormaster completed remote builds in B31748: Diff 44384.Fri, Sep 20, 7:23 AM
bartek added a child revision: D13415: [lib] Establish holders for DM multimedia.Fri, Sep 20, 7:39 AM
kamil accepted this revision.Mon, Sep 23, 12:37 AM
This revision is now accepted and ready to land.Mon, Sep 23, 12:37 AM
Closed by commit rCOMM7ab6657dfa3c: [lib] Create holder ops for thick thread avatars (authored by bartek). · Explain WhyMon, Sep 23, 7:24 AM
This revision was automatically updated to reflect the committed changes.
bartek mentioned this in rCOMM1dea35865e35: [lib] Process blob holders in DM ops.
bartek added a commit: rCOMM7ab6657dfa3c: [lib] Create holder ops for thick thread avatars.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
32 lines

Diff 44381

View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...