Page MenuHomePhabricator
Differential D13403

[lib] Add reducer and action to store established holder
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 3:52 AM.
Tags
None
Referenced Files
F5076321: D13403.diff
Fri, Mar 28, 7:32 PM
Unknown Object (File)
Fri, Feb 28, 9:26 AM
Unknown Object (File)
Fri, Feb 28, 8:12 AM
Unknown Object (File)
Feb 23 2025, 12:19 AM
Unknown Object (File)
Feb 6 2025, 10:39 AM
Unknown Object (File)
Feb 6 2025, 5:25 AM
Unknown Object (File)
Feb 6 2025, 3:57 AM
Unknown Object (File)
Feb 6 2025, 3:57 AM
View All 69 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM79e2ffe30f49: [lib] Add reducer and action to store established holder
Summary

First action from ENG-9285. Addresses ENG-9286.

Added reducer for holders and action to store already-established holder in the store.
We use it in the blob service upload hook, to store the initial holder, which previously was forgotten

Inspired by D12949

Depends on D13401, D13402

Test Plan
  • Reducer unit test
  • Uploaded multimedia to a DM thread and used Redux Devtools to ensure the action was performed correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 20 2024, 3:52 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 3:52 AM
Harbormaster completed remote builds in B31731: Diff 44361.Sep 20 2024, 4:08 AM
bartek published this revision for review.Sep 20 2024, 4:20 AM
ashoat added inline comments.Sep 20 2024, 5:50 AM
lib/actions/upload-actions.js
155–158 ↗(On Diff #44361)

Why isn't this type read-only?

kamil accepted this revision.Sep 20 2024, 6:08 AM
kamil added inline comments.
lib/reducers/holder-reducer.js
17 ↗(On Diff #44361)

Is it possible to have this holder in store already?

lib/reducers/holder-reducer.test.js
23 ↗(On Diff #44361)

nice

This revision is now accepted and ready to land.Sep 20 2024, 6:08 AM
bartek added a child revision: D13408: [lib] Add action type for processing holders.Sep 20 2024, 6:21 AM
bartek added inline comments.Sep 23 2024, 4:20 AM
lib/actions/upload-actions.js
155–158 ↗(On Diff #44361)

Not sure, but making readonly didn't break Flow so I guess we can do it.

lib/reducers/holder-reducer.js
17 ↗(On Diff #44361)

In theory, it could but in current implementation not really

bartek updated this revision to Diff 44412.Sep 23 2024, 4:20 AM

Feedback

Harbormaster completed remote builds in B31766: Diff 44412.Sep 23 2024, 4:37 AM
Closed by commit rCOMM79e2ffe30f49: [lib] Add reducer and action to store established holder (authored by bartek). · Explain WhySep 23 2024, 7:24 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM79e2ffe30f49: [lib] Add reducer and action to store established holder.

Revision Contents
Changeset List

PathSize
lib/
actions/
7 lines
22 lines
reducers/
28 lines
23 lines
2 lines
types/
5 lines

Diff 44412

View Options

lib/actions/holder-actions.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/actions/upload-actions.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/reducers/holder-reducer.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/reducers/holder-reducer.test.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...