[lib] Add reducer and action to store established holder
ClosedPublic
Actions

Authored by bartek on Sep 20 2024, 3:52 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM79e2ffe30f49: [lib] Add reducer and action to store established holder

Summary

First action from ENG-9285. Addresses ENG-9286.

Added reducer for holders and action to store already-established holder in the store.
We use it in the blob service upload hook, to store the initial holder, which previously was forgotten

Inspired by D12949

Depends on D13401, D13402

Test Plan

Reducer unit test
Uploaded multimedia to a DM thread and used Redux Devtools to ensure the action was performed correctly

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 20 2024, 3:52 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2024, 3:52 AM

Harbormaster completed remote builds in B31731: Diff 44361.Sep 20 2024, 4:08 AM

bartek published this revision for review.Sep 20 2024, 4:20 AM

ashoat added inline comments.Sep 20 2024, 5:50 AM

lib/actions/upload-actions.js
155–158 ↗	(On Diff #44361)	Why isn't this type read-only?

kamil accepted this revision.Sep 20 2024, 6:08 AM

kamil added inline comments.

lib/reducers/holder-reducer.js
17 ↗	(On Diff #44361)	Is it possible to have this holder in store already?
lib/reducers/holder-reducer.test.js
23 ↗	(On Diff #44361)	nice

This revision is now accepted and ready to land.Sep 20 2024, 6:08 AM

bartek added a child revision: D13408: [lib] Add action type for processing holders.Sep 20 2024, 6:21 AM

bartek added inline comments.Sep 23 2024, 4:20 AM

lib/actions/upload-actions.js
155–158 ↗	(On Diff #44361)	Not sure, but making readonly didn't break Flow so I guess we can do it.
lib/reducers/holder-reducer.js
17 ↗	(On Diff #44361)	In theory, it could but in current implementation not really